mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 20:17:51 +02:00
I'm setting it to three buckets across all tests, because the default one bucket wasn't realistic enough, and allowed some tests to pass that shouldn't have, essentially by accident. This also changes RegistryConfig from being an interface to being an abstract base class. The medium term goal here is to have it be a static class so that it can provide fields from the YAML-derived POJO in situations where Dagger injection isn't feasible. The expected end state is as follows: default-config.yaml -- The master config file that provides defaults for all values. nomulus-config.yaml -- A per-environment config file that overrides the defaults from the previous file. YamlConfig.java -- The POJO that the aforementioned YAML files are deserialized into. RegistryConfig.java -- Contains a static, memoized instance of YamlConfig and provides static methods for getting some of those values. ConfigModule -- Will become a static inner class of RegistryConfig, using Dagger to provide most of the fields from the memoized YamlConfig instance. This way, all configuration will be coming from a single place: RegistryConfig.java. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=143567288
118 lines
4.1 KiB
Java
118 lines
4.1 KiB
Java
// Copyright 2016 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.model.ofy;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.ofy.CommitLogBucket.getBucketKey;
|
|
import static google.registry.model.ofy.CommitLogBucket.loadAllBuckets;
|
|
import static google.registry.model.ofy.CommitLogBucket.loadBucket;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.util.DateTimeUtils.END_OF_TIME;
|
|
|
|
import com.google.common.base.Suppliers;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.googlecode.objectify.annotation.Cache;
|
|
import google.registry.testing.AppEngineRule;
|
|
import google.registry.testing.ExceptionRule;
|
|
import google.registry.testing.InjectRule;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Tests for {@link CommitLogBucket}. */
|
|
@RunWith(JUnit4.class)
|
|
public class CommitLogBucketTest {
|
|
|
|
@Rule
|
|
public final AppEngineRule appEngine = AppEngineRule.builder()
|
|
.withDatastore()
|
|
.build();
|
|
|
|
@Rule
|
|
public final InjectRule inject = new InjectRule();
|
|
|
|
@Rule
|
|
public final ExceptionRule thrown = new ExceptionRule();
|
|
|
|
CommitLogBucket bucket;
|
|
|
|
@Before
|
|
public void before() {
|
|
// Save the bucket with some non-default properties set so that we can distinguish a correct
|
|
// load from one that returns a newly created bucket instance.
|
|
bucket = persistResource(
|
|
new CommitLogBucket.Builder()
|
|
.setLastWrittenTime(END_OF_TIME)
|
|
.setBucketNum(1)
|
|
.build());
|
|
}
|
|
|
|
@Test
|
|
public void test_getBucketKey_createsBucketKeyInDefaultNamespace() {
|
|
// Key.getNamespace() returns the empty string for the default namespace, not null.
|
|
assertThat(getBucketKey(1).getRaw().getNamespace()).isEmpty();
|
|
}
|
|
|
|
@Test
|
|
public void test_getBucketKey_bucketNumberTooLow_throws() {
|
|
thrown.expect(IllegalArgumentException.class, "0 not in [");
|
|
getBucketKey(0);
|
|
}
|
|
|
|
@Test
|
|
public void test_getBucketKey_bucketNumberTooHigh_throws() {
|
|
thrown.expect(IllegalArgumentException.class, "11 not in [");
|
|
getBucketKey(11);
|
|
}
|
|
|
|
@Test
|
|
public void test_getArbitraryBucketId_withSupplierOverridden() {
|
|
inject.setStaticField(
|
|
CommitLogBucket.class, "bucketIdSupplier", Suppliers.ofInstance(4)); // xkcd.com/221
|
|
// Try multiple times just in case it's actually still random. If it is, the probability of
|
|
// this test passing is googol^-1, so I think we're pretty safe.
|
|
for (int i = 0; i < 100; i++) {
|
|
assertThat(CommitLogBucket.getArbitraryBucketId()).isEqualTo(4);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void test_loadBucket_loadsTheBucket() {
|
|
assertThat(loadBucket(getBucketKey(1))).isEqualTo(bucket);
|
|
}
|
|
|
|
@Test
|
|
public void test_loadBucket_forNonexistentBucket_returnsNewBucket() {
|
|
assertThat(loadBucket(getBucketKey(3))).isEqualTo(
|
|
new CommitLogBucket.Builder().setBucketNum(3).build());
|
|
}
|
|
|
|
@Test
|
|
public void test_loadAllBuckets_loadsExistingBuckets_orNewOnesIfNonexistent() {
|
|
ImmutableSet<CommitLogBucket> buckets = loadAllBuckets();
|
|
assertThat(buckets).hasSize(3);
|
|
assertThat(buckets).contains(bucket);
|
|
assertThat(buckets).contains(new CommitLogBucket.Builder().setBucketNum(2).build());
|
|
assertThat(buckets).contains(new CommitLogBucket.Builder().setBucketNum(3).build());
|
|
}
|
|
|
|
@Test
|
|
public void test_noCacheAnnotation() {
|
|
// Don't ever put @Cache on CommitLogBucket; it could mess up the checkpointing algorithm.
|
|
assertThat(CommitLogBucket.class.isAnnotationPresent(Cache.class)).isFalse();
|
|
}
|
|
}
|