zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-03 21:47:51 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/flows
History
nickfelt f640d765e8 Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 
The logging for exceptions in FlowRunner - always at WARNING - has long been sub-optimal.  For EppExceptions it's too aggressive/spammy to log at WARNING because it's generally not actionable - EppException gets properly thrown for all kinds of ordinary reasons (trying to create a resource when one already exists with that foreign key) and/or for client misbehavior that we can't control (sending bad parameter values, etc.).  For non-EppException RuntimeExceptions, it's redundant with existing logging in EppController.

This CL resolves this by removing that logging in FlowRunner entirely in favor of the EppController logging, where we're now logging EppExceptions at INFO in parallel with the existing logging of RuntimeExceptions at SEVERE.  This has the benefit that we're now logging EppExceptions that come from FlowPicker (by way of EppExceptionInProviderException),  which previously were unlogged.

Note however that this does mean that in places where we run FlowRunner without EppController - exclusively test code as it stands today - we'd no longer be logging EppExceptions.  If that seems like a loss, we could either reinstate logging there (at INFO) and just deal with redundant messages for most EppExceptions, or we could add it manually to places where we call FlowRunner.run() in tests and avoid the redundancy that way.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=154733365
2017-05-03 11:04:51 -04:00
..
annotations Make FlowRunner log ICANN activity report field name 2017-03-27 13:32:57 -04:00
async Notify registrars of async contact/host deletions 2017-04-26 10:33:55 -04:00
contact Notify registrars of async contact/host deletions 2017-04-26 10:33:55 -04:00
custom Restrict domain transfer pricing to 1 year 2017-03-21 15:33:29 -04:00
domain Make DomainInfoFlow (and application info) explicitly hit memcache 2017-05-03 10:49:38 -04:00
exceptions Use StatusValue XML names in EPP error messages 2017-03-21 15:14:02 -04:00
host Fix bug which allowed creation of hosts with superordinate domains in pending delete state. 2017-05-03 11:03:23 -04:00
picker Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
poll Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
session Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
soy Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
CheckApiAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppConsoleAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppController.java Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 2017-05-03 11:04:51 -04:00
EppException.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetrics.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestHandler.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestSource.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppTlsAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppToolAction.java Set correct auth settings for all actions 2017-03-13 11:22:55 -04:00
EppXmlTransformer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ExtensionManager.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Flow.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowComponent.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowModule.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
FlowReporter.java Fix Java 7 missing generic type error 2017-04-26 11:02:02 -04:00
FlowRunner.java Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 2017-05-03 11:04:51 -04:00
FlowScope.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GaeUserCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HttpSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PasswordOnlyTransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ResourceFlowUtils.java Remove straggler references to extended registration years 2017-03-27 12:59:48 -04:00
ServerTridProvider.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
ServerTridProviderImpl.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
ServerTridProviderModule.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
SessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
StatelessRequestSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TlsCredentials.java Fix incorrect header name in TlsCredentials javadoc 2017-05-03 10:48:01 -04:00
TransactionalFlow.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
TransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00