mirror of
https://github.com/google/nomulus.git
synced 2025-08-03 00:12:11 +02:00
bb7d0b6b89
* Fix entity delete replication, compare db @ replay Replay tests currently only verify that the contents of a transaction are can be successfully replicated to the other database. They do not verify that the contents of both databases are equivalent. As a result, we miss any changes omitted from the transaction (as was the case with entity deletions). This change adds a final database comparison to ReplayExtension so we can safely say that the databases are in the same state. This comparison is introduced in part as a unit test for the one-line fix for replication of an "entity delete" operation (where we delete using an entity object instead of the object's key) which so far has only affected PollMessage deletion. The fix is also included in this commit within JpaTransactionManagerImpl. * Exclude tests and entities with failing comparisons * Get all tests to pass and fix more timestamp Fix most of the unit tests that were broken by this change. - Fix timestamp updates after grace period changes in DomainContent and for TLD changes in Registrar. - Reenable full database comparison for most DomainCreateFlowTest's. - Make some test entities NonReplicated so they don't break when used with jpaTm().delete() - Diable checking of a few more entity types that are failing comparisons. - Add some formatting fixes. * Remove unnecessary "NoDatabaseCompare" I turns out that after other fixes/elisions we no longer need these for any tests in DomainCreateFlowTest. * Changes for review * Remove old "compare" flag. * Reformatted. |
||
|---|---|---|
| .. | ||
| gradle/dependency-locks | ||
| src | ||
| build.gradle | ||
| Dockerfile | ||