mcilwain b8d7d9da29 Don't delete the old premium list yet after updating to a new one ... The issue is that the premium list cache is configured to persist for 60 minutes. So after updating the list, checks/creates for up to the next 60 minutes could still be referring to the old list. That's fine and dandy, unless you delete the old premium list immediately (*bad*), which makes all domains appear to now be non-premium for as long as the cache lasts. The reason deleting the premium list entries makes names appear as non-premium is that a load-by-key existence check with the domain label itself is used to determine if a name is premium. I also removed a misleading cache update statement, which doesn't do what it appears to be doing (it appears to fix this issue) because cache is instance-level, and so even if the premium list were updated from the frontend instance only one of 100 instances would have its cache updated. But it's updated from the tools service anyway, so it's guaranteed to not be a shared cache with any instance serving EPP traffic. On a sidenote, I introduced this bug on 2014-10-27 in [] The domain label list refactor was my Noogler project. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=197033604		2018-05-17 21:52:35 -04:00
..
com/google/testing/builddefs	Replace PACKAGE_NAME with package_name() in bzl files.	2018-04-02 16:18:55 -04:00
google/registry	Don't delete the old premium list yet after updating to a new one	2018-05-17 21:52:35 -04:00