mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 20:17:51 +02:00
898448b8a0
Certain flows need to launch batched jobs. Logically this would mean that flows depend on batch. However, the current state of dependency was the other way around, and the reason for that was ResourceFlowUtils.java that had in it some utility functions that weren't used in the flows and were needed in the batch jobs. This CL removes these utility functions from the /flows/ directory, letting us reverse the dependency edge between flows/ and batch/ Part of this was moving the flows/async/ code into batch/ - which also makes sense because flows/async/ just "enqueued" tasks that would then be run by actions in batch/ It makes sense that the code that enqueues the tasks and the code that dequeues the tasks sit in the same library. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=228698761
51 lines
2.1 KiB
Java
51 lines
2.1 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.batch;
|
|
|
|
import static com.google.monitoring.metrics.contrib.DistributionMetricSubject.assertThat;
|
|
import static com.google.monitoring.metrics.contrib.LongMetricSubject.assertThat;
|
|
import static google.registry.batch.AsyncTaskMetrics.OperationResult.SUCCESS;
|
|
import static google.registry.batch.AsyncTaskMetrics.OperationType.CONTACT_AND_HOST_DELETE;
|
|
|
|
import com.google.common.collect.ImmutableSet;
|
|
import google.registry.testing.FakeClock;
|
|
import google.registry.testing.ShardableTestCase;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link AsyncTaskMetrics}. */
|
|
@RunWith(JUnit4.class)
|
|
public class AsyncTaskMetricsTest extends ShardableTestCase {
|
|
|
|
private final FakeClock clock = new FakeClock();
|
|
private final AsyncTaskMetrics asyncTaskMetrics = new AsyncTaskMetrics(clock);
|
|
|
|
@Test
|
|
public void testRecordAsyncFlowResult_calculatesDurationMillisCorrectly() {
|
|
asyncTaskMetrics.recordAsyncFlowResult(
|
|
CONTACT_AND_HOST_DELETE,
|
|
SUCCESS,
|
|
clock.nowUtc().minusMinutes(10).minusSeconds(5).minusMillis(566));
|
|
assertThat(AsyncTaskMetrics.asyncFlowOperationCounts)
|
|
.hasValueForLabels(1, "contactAndHostDelete", "success")
|
|
.and()
|
|
.hasNoOtherValues();
|
|
assertThat(AsyncTaskMetrics.asyncFlowOperationProcessingTime)
|
|
.hasDataSetForLabels(ImmutableSet.of(605566.0), "contactAndHostDelete", "success")
|
|
.and()
|
|
.hasNoOtherValues();
|
|
}
|
|
}
|