google-nomulus/javatests/google/registry
mcilwain 49ac4e3e69 Improve Datastore efficiency of duplicate contact messages
I should have caught this in the review, but [] is loading *ALL*
contacts individually from Datastore on every domain update. This will add a
large number of Datastore round trips and thus significantly reduce update
performance.

This CL changes the behavior to *ONLY* load contacts when there is a duplicate
(which is needed to determine the contact's display name to generate the error
message), and loads all of them in a single batch rather than individually.

This also makes some minor changes around domain getters returning empty sets
instead of null.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=233128140
2019-02-11 11:22:34 -05:00
..
backup Fix some issues caught by IntelliJ static code analysis 2019-01-28 16:08:24 -05:00
batch Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
beam Run the Spec11 pipeline daily without sending emails 2018-12-12 13:22:34 -05:00
bigquery Use @DefaultCredential for Cloud API access in GAE 2018-09-20 11:19:36 -04:00
builddefs Format .bzl files with buildifier 2018-07-14 01:37:03 -04:00
config Configure client id and client secret in the config file 2018-12-05 16:04:08 -05:00
cron Clean up third_party imports in BUILD files 2018-07-14 01:11:51 -04:00
dns Switch to constructor injection in a few actions 2019-02-06 17:53:49 -05:00
export Use -dot- subdomain notation in MapReduce console links 2019-01-31 13:59:05 -05:00
flows Improve Datastore efficiency of duplicate contact messages 2019-02-11 11:22:34 -05:00
groups Add support G-Suite group whose members have ADMIN access to registrar console 2018-11-12 14:51:40 -05:00
keyring Rename DNL and SMDRL "login" to "loginAndPassword" 2019-01-28 16:15:04 -05:00
mapreduce/inputs Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
model Make a prettier table to display OT&E check results 2019-01-28 16:10:16 -05:00
module Delete the mapreduce poll action 2019-02-01 16:24:37 -05:00
monitoring/whitebox Stop exporting EPP flow metrics to BigQuery 2018-10-08 16:59:29 -04:00
pricing Clean up third_party imports in BUILD files 2018-07-14 01:11:51 -04:00
proxy Fix some issues caught by IntelliJ static code analysis 2019-01-28 16:08:24 -05:00
rdap Run more formatting fixes in preparation for the open-source change 2019-02-06 17:49:11 -05:00
rde Delete everything related to RDE import 2019-01-28 16:16:36 -05:00
reporting Move LocalDate injection to the Actions themselves 2019-02-06 17:52:16 -05:00
request Add the App Engine service used in the Action definition 2019-01-17 18:59:16 -05:00
security Improve internal build system speed 2018-06-27 15:28:52 -04:00
server Make a prettier table to display OT&E check results 2019-01-28 16:10:16 -05:00
storage/drive Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
testing Switch to constructor injection in a few actions 2019-02-06 17:53:49 -05:00
tldconfig/idn Remove the use of InjectRule in IdnLabelValidatorTest 2018-10-22 18:54:53 -04:00
tmch Make logged response in NordnUploadAction intelligible 2019-02-01 16:20:01 -05:00
tools Switch to constructor injection in a few actions 2019-02-06 17:53:49 -05:00
ui Make a prettier table to display OT&E check results 2019-01-28 16:10:16 -05:00
util Run more formatting fixes in preparation for the open-source change 2019-02-06 17:49:11 -05:00
whois Change redacted output for domain whois query 2019-02-06 18:03:11 -05:00
xjc Clean up internal imports in BUILD files 2018-07-14 01:37:03 -04:00
xml Fix some issues caught by IntelliJ static code analysis 2019-01-28 16:08:24 -05:00