mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 20:47:52 +02:00
9d2b1e7572
Currently, we have two different ways to parse a "set" parameter: key=value1&key=value2&key=value3... and keys=value1,value2,value3 This is error prone for several reasons: - different parts of the code must be "synchronized" to use the same style (the place that creates the request, and the place that parses the request) - for the key=value1&key=value2, we often use the same key name for the single value and the set value. This can result in subtle bugs where part of the code will successfully read the key assuming there's only one key (and will get the first key=value1, ignoring the rest) Here we transition everything to the keys=value1,value2,value3 method. This one was chosen because: - it's shorter - it's more intuitive for users - the key name is plural, differentiating it from the singular key=value that other requests might need ----------------------------------- To make sure there are not "transition issues", we will continue to support (with warnings) the key=value1&key=value2 parameter parsing until we're sure we haven't forgotten to update any part of the code. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=198810681
60 lines
2.2 KiB
Java
60 lines
2.2 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.module.backend;
|
|
|
|
import static google.registry.model.registry.Registries.assertTldExists;
|
|
import static google.registry.model.registry.Registries.assertTldsExist;
|
|
import static google.registry.request.RequestParameters.extractOptionalDatetimeParameter;
|
|
import static google.registry.request.RequestParameters.extractRequiredParameter;
|
|
import static google.registry.request.RequestParameters.extractSetOfParameters;
|
|
|
|
import com.google.common.collect.ImmutableSet;
|
|
import dagger.Module;
|
|
import dagger.Provides;
|
|
import google.registry.batch.ExpandRecurringBillingEventsAction;
|
|
import google.registry.request.Parameter;
|
|
import google.registry.request.RequestParameters;
|
|
import java.util.Optional;
|
|
import javax.servlet.http.HttpServletRequest;
|
|
import org.joda.time.DateTime;
|
|
|
|
/**
|
|
* Dagger module for injecting common settings for all Backend tasks.
|
|
*/
|
|
@Module
|
|
public class BackendModule {
|
|
|
|
@Provides
|
|
@Parameter(RequestParameters.PARAM_TLD)
|
|
static String provideTld(HttpServletRequest req) {
|
|
return assertTldExists(extractRequiredParameter(req, RequestParameters.PARAM_TLD));
|
|
}
|
|
|
|
@Provides
|
|
@Parameter(RequestParameters.PARAM_TLDS)
|
|
static ImmutableSet<String> provideTlds(HttpServletRequest req) {
|
|
ImmutableSet<String> tlds =
|
|
extractSetOfParameters(req, RequestParameters.PARAM_TLDS, RequestParameters.PARAM_TLD);
|
|
assertTldsExist(tlds);
|
|
return tlds;
|
|
}
|
|
|
|
@Provides
|
|
@Parameter("cursorTime")
|
|
static Optional<DateTime> provideCursorTime(HttpServletRequest req) {
|
|
return extractOptionalDatetimeParameter(
|
|
req, ExpandRecurringBillingEventsAction.PARAM_CURSOR_TIME);
|
|
}
|
|
}
|