d3e25cd5b1
Identified a few more tests that are impacted by test cleanup issues outside of Nomulus code base, more likely thread pool cleanup behaviors in AppEngine testing fixture. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=229934266 |
||
|---|---|---|
| .. | ||
| core | ||
| gradle/wrapper | ||
| proxy | ||
| services | ||
| third_party | ||
| util | ||
| build.gradle | ||
| dependencies.gradle | ||
| generate_dependency_metadata.sh | ||
| gradlew | ||
| gradlew.bat | ||
| README.md | ||
| settings.gradle | ||
| update_dependency.sh | ||
This folder contains experimental Gradle scripts as an alternative to Bazel for the open-source Nomulus project. These are work-in-progress and are expected to evolve in the near future.
All testing is done with Gradle v4.10.2.
Current status
Currently there are two sub-projects, third_party, which contains the back-ported JUnit 4.13 code; and core, which contains all Nomulus source code. Gradle can be used to compile and run all Java tests.
Gradle is configured to use the directory containing this file as root, but use the existing Nomulus source tree.
Dependencies are mostly the same as in Bazel, with a few exceptions:
- com.googlecode.java-diff-utils:diffutils is not included. Bazel needs it for Truth's equality check, but Gradle works fine without it.
- jaxb 2.2.11 is used instead of 2.3 in Bazel, since the latter breaks the ant.xjc task. The problem is reportedly fixed in jaxb 2.4.
- The other dependencies are copied from Nomulus' repository.bzl config.
- We still need to verify if there are unused dependencies.
- Many dependencies are behind their latest versions.
Notable Issues
Test suites (RdeTestSuite and TmchTestSuite) are ignored to avoid duplicate execution of tests. Neither suite performs any shared test setup routine, so it is easier to exclude the suite classes than individual test classes. This is the reason why all test tasks in the :core project contain the exclude pattern '"/TestCase.", "/TestSuite."'
Many Nomulus tests are not hermetic: they modify global state (e.g., the shared local instance of Datastore) but do not clean up on completion. This becomes a problem with Gradle. In the beginning we forced Gradle to run every test class in a new process, and incurred heavy overheads. Since then, we have fixed some tests, and manged to divide all tests into three suites that do not have intra-suite conflicts. We will revisit the remaining tests soon.
Note that it is unclear if all conflicting tests have been identified. More may be exposed if test execution order changes, e.g., when new tests are added or execution parallelism level changes.
Initial Setup
Install Gradle on your local host, then run the following commands from this directory:
# One-time command to add gradle wrapper:
gradle wrapper
# Start the build:
./gradlew build
From now on, use './gradlew build' or './gradlew test' to build and test your changes.
To upgrade to a new Gradle version for this project, use:
gradle wrapper --gradle-version version-number