google-nomulus/java/google/registry
mountford ac822053cc Change behavior when searching contacts by name
We no longer find contacts by name if the request is not authorized to see the name.

Several changes cascade from this. Previously, the code assumed that deleted contacts might still have full names, and therefore be searchable. This is not possible in all cases, because Datastore doesn't have the right index to find deleted contacts by name with a matching registrar. However, luckily, this situation can never occur, because contacts always have their name fields nulled out when they are deleted.

So instead, we simply ignore deleted records when searching by name, knowing that none can ever match.

The tests were then changed so that deleted records look the way the really will, meaning devoid of personal information.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172776926
2017-10-24 16:53:47 -04:00
..
backup Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
batch Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
bigquery Format some imports using fix_imports.py 2017-10-24 16:53:47 -04:00
braintree Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
builddefs Rename set to depset in .bzl and BUILD files 2017-08-29 16:53:21 -04:00
config Fix problem with RDAP help information 2017-10-24 16:53:47 -04:00
cron Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
dns Translate multi-part TLD zone names 2017-10-24 16:53:47 -04:00
eclipse Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
env Add RDAP support for deleted domains and filtering by registrar 2017-10-24 16:53:47 -04:00
export Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
flows Rename ClaimsCheckFlow to DomainClaimsCheckFlow 2017-10-24 16:53:47 -04:00
gcs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
groups Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
idn Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
keyring Format some imports using fix_imports.py 2017-10-24 16:53:47 -04:00
loadtest Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
mapreduce Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
model Convert domain label list code to use Java 8 streams features 2017-10-24 16:53:47 -04:00
module Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
monitoring Format some imports using fix_imports.py 2017-10-24 16:53:47 -04:00
pricing Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
rdap Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
rde Remove reference to TLD in Locks' ResourceName 2017-10-24 16:53:47 -04:00
reporting Prepare ICANN reporting for production 2017-10-24 16:53:47 -04:00
request Prepare ICANN reporting for production 2017-10-24 16:53:47 -04:00
security Remove XsrfTokenManager fallback for validating legacy tokens 2017-03-21 15:36:31 -04:00
storage/drive Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tldconfig/idn Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
tmch Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
tools Fix NPE in GetHistoryEntriesCommand 2017-10-24 16:53:47 -04:00
ui Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
util Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
whois Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
xjc Fix the build on MacOS 2017-07-12 11:03:50 -04:00
xml Add support for a domain delete superuser EPP extension 2017-09-12 15:51:50 -04:00
BUILD Add nocron ear and deployer rules for the crash environment 2017-10-04 16:16:45 -04:00
repositories.bzl Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00