mirror of
https://github.com/google/nomulus.git
synced 2025-05-09 08:18:21 +02:00
It's best to be consistent and use the same thing everywhere. "clientId" was already used in more places and is shorter and no more ambiguous, so it's the logical one to win out. Note that this CL is almost solely a big Eclipse-assisted refactoring. There are two places that I did not change clientIdentifier -- the actual entity field on Registrar (though I did change all getters and setters), and the name of a column on the exported registrar spreadsheet. Both would require data migrations. Also fixes a few minor nits discovered in touched files, including an incorrect test in OfyFilterTest.java and some superfluous uses of String.format() when calling checkArgument(). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=133956465
160 lines
6.6 KiB
Java
160 lines
6.6 KiB
Java
// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.io.BaseEncoding.base16;
|
|
import static com.google.common.io.Resources.getResource;
|
|
import static com.google.common.io.Resources.toByteArray;
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.flows.EppXmlTransformer.unmarshal;
|
|
import static google.registry.flows.picker.FlowPicker.getFlowClass;
|
|
import static google.registry.model.domain.DesignatedContact.Type.ADMIN;
|
|
import static google.registry.model.domain.DesignatedContact.Type.BILLING;
|
|
import static google.registry.model.domain.DesignatedContact.Type.TECH;
|
|
import static google.registry.model.domain.launch.ApplicationStatus.VALIDATED;
|
|
import static google.registry.model.registry.Registry.TldState.QUIET_PERIOD;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.DatastoreHelper.newDomainApplication;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveContact;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveHost;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.util.DateTimeUtils.START_OF_TIME;
|
|
import static google.registry.util.ResourceUtils.readResourceBytes;
|
|
|
|
import com.beust.jcommander.ParameterException;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.googlecode.objectify.Key;
|
|
import google.registry.flows.domain.DomainAllocateFlow;
|
|
import google.registry.model.domain.DesignatedContact;
|
|
import google.registry.model.domain.DomainApplication;
|
|
import google.registry.model.domain.launch.LaunchNotice;
|
|
import google.registry.model.domain.secdns.DelegationSignerData;
|
|
import google.registry.model.eppcommon.Trid;
|
|
import google.registry.model.eppinput.EppInput;
|
|
import google.registry.model.reporting.HistoryEntry;
|
|
import google.registry.tools.ServerSideCommand.Connection;
|
|
import java.io.IOException;
|
|
import org.joda.time.DateTime;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.mockito.Mock;
|
|
|
|
/** Unit tests for {@link AllocateDomainCommand}. */
|
|
public class AllocateDomainCommandTest extends CommandTestCase<AllocateDomainCommand> {
|
|
|
|
@Mock
|
|
Connection connection;
|
|
|
|
@Before
|
|
public void init() throws IOException {
|
|
command.setConnection(connection);
|
|
createTld("tld", QUIET_PERIOD);
|
|
createApplication("example-one.tld", "testdata/domain_create_sunrush.xml", "1-TLD");
|
|
createApplication("example-two.tld", "testdata/domain_create_sunrush2.xml", "2-TLD");
|
|
}
|
|
|
|
private void createApplication(String name, String xmlFile, String repoId) throws IOException {
|
|
DomainApplication application =
|
|
persistResource(newDomainApplication(name)
|
|
.asBuilder()
|
|
.setRepoId(repoId)
|
|
.setCreationTimeForTest(START_OF_TIME)
|
|
.setRegistrant(Key.create(persistActiveContact("registrant")))
|
|
.setContacts(ImmutableSet.of(
|
|
DesignatedContact.create(
|
|
ADMIN,
|
|
Key.create(persistActiveContact("adminContact"))),
|
|
DesignatedContact.create(
|
|
BILLING,
|
|
Key.create(persistActiveContact("billingContact"))),
|
|
DesignatedContact.create(
|
|
TECH,
|
|
Key.create(persistActiveContact("techContact")))))
|
|
.setNameservers(ImmutableSet.of(
|
|
Key.create(persistActiveHost("ns1.example.com")),
|
|
Key.create(persistActiveHost("ns2.example.com"))))
|
|
.setApplicationStatus(VALIDATED)
|
|
.setDsData(ImmutableSet.of(
|
|
DelegationSignerData.create(
|
|
12345, 3, 1, base16().decode("49FD46E6C4B45C55D4AC")),
|
|
DelegationSignerData.create(
|
|
56789, 2, 4, base16().decode("69FD46E6C4A45C55D4AC"))))
|
|
.setLaunchNotice(LaunchNotice.create(
|
|
"370d0b7c9223372036854775807",
|
|
"tmch",
|
|
DateTime.parse("2010-08-16T09:00:00.0Z"),
|
|
DateTime.parse("2009-08-16T09:00:00.0Z")))
|
|
.build());
|
|
persistResource(
|
|
new HistoryEntry.Builder()
|
|
.setParent(application)
|
|
.setClientId("NewRegistrar")
|
|
.setModificationTime(application.getCreationTime())
|
|
.setTrid(Trid.create("ABC-123"))
|
|
.setXmlBytes(toByteArray(getResource(AllocateDomainCommandTest.class, xmlFile)))
|
|
.build());
|
|
}
|
|
|
|
private EppToolVerifier eppVerifier() {
|
|
return new EppToolVerifier()
|
|
.withConnection(connection)
|
|
.withClientId("TheRegistrar")
|
|
.asSuperuser();
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess() throws Exception {
|
|
runCommand("--ids=1-TLD", "--force", "--superuser");
|
|
// NB: These commands are sent as the sponsoring registrar, in this case "TheRegistrar".
|
|
eppVerifier().verifySent("allocate_domain.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_multiple() throws Exception {
|
|
runCommand("--ids=1-TLD,2-TLD", "--force", "--superuser");
|
|
eppVerifier().verifySent("allocate_domain.xml", "allocate_domain2.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_dryRun() throws Exception {
|
|
runCommand("--ids=1-TLD", "--dry_run", "--superuser");
|
|
eppVerifier().asDryRun().verifySent("allocate_domain.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_notAsSuperuser() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class);
|
|
runCommand("--ids=1-TLD", "--force");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_forceAndDryRunIncompatible() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class);
|
|
runCommand("--ids=1-TLD", "--force", "--dry_run", "--superuser");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_unknownFlag() throws Exception {
|
|
thrown.expect(ParameterException.class);
|
|
runCommand("--ids=1-TLD", "--force", "--unrecognized=foo", "--superuser");
|
|
}
|
|
|
|
@Test
|
|
public void testXmlInstantiatesFlow() throws Exception {
|
|
byte[] xmlBytes = readResourceBytes(getClass(), "testdata/allocate_domain.xml").read();
|
|
assertThat(getFlowClass(unmarshal(EppInput.class, xmlBytes)))
|
|
.isEqualTo(DomainAllocateFlow.class);
|
|
}
|
|
}
|