zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-01 20:47:52 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/model
History
jianglai ff221fba96 Validate individual fee types 
Currently we validate the fee extension by summing up all fees present in the extension and comparing it against the total fee to be charged. While this works in most cases, we'd like the ability to individually validate each fee. This is especially useful during EAP when two fees are charged, a regular "create" fee that would also be amount we charge during renewal, and a one time "EAP" fee.

Because we can only distinguish fees by their descriptions, we try to match the description to the format string of the fee type enums. We also only require individual fee matches when we are charging more than one type of fees, which makes the change compatible with most existing use cases where only one fees is charged and the description field is ignored in the extension.

We expect the workflow to be that a registrar sends a domain check, and we reply with exactly what fees we are expecting, and then it will use the descriptions in the response to send us a domain create with the correct fees.

Note that we aggregate fees within the same FeeType together. Normally there will only be one fee per type, but in case of custom logic there could be more than one fee for the same type. There is no way to distinguish them as they both use the same description. So it is simpler to just aggregate them.

This CL also includes some reformatting that conforms to google-java-format output.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=186530316
2018-03-06 18:48:39 -05:00
..
annotations Clean up some code quality issues 2017-12-01 22:14:06 -05:00
billing Add an EPP lifecycle test verifying that EAP fees are not refunded 2017-12-27 11:29:07 -05:00
common Replace FluentIterable with streams 2017-12-27 11:40:50 -05:00
contact Migrate Guava Predicates.notNull to Objects.nonNull 2017-12-27 11:19:53 -05:00
domain Validate individual fee types 2018-03-06 18:48:39 -05:00
eppcommon Clean up some code quality issues 2017-12-01 22:14:06 -05:00
eppinput Make EppInput.getSingleExtension() return Optional, not @Nullable 2018-01-19 14:40:10 -05:00
eppoutput Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
host Format some imports using fix_imports.py 2017-10-24 16:53:47 -04:00
index Refactor Guava functional methods to use lambdas 2017-12-01 22:14:05 -05:00
mark Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ofy Replace FluentIterable with streams 2017-12-27 11:40:50 -05:00
poll Remove leniency on poll message ID format without years in them 2018-02-20 15:12:43 -05:00
pricing Clean up some code quality issues 2017-12-01 22:14:06 -05:00
rde Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
registrar Add the ability to require premium fee acking for a registrar 2018-02-01 22:07:11 -05:00
registry Add the START_DATE_SUNRISE phase 2018-02-20 15:45:27 -05:00
reporting Fix NPE in GetHistoryEntriesCommand 2017-10-24 16:53:47 -04:00
server Move metrics dependencies to artifacts under Maven groupId com.google.monitoring-client 2018-01-04 17:12:35 -05:00
smd Replace FluentIterable with streams 2017-12-27 11:40:50 -05:00
tmch Refactor Guava functional methods to use lambdas 2017-12-01 22:14:05 -05:00
transfer Clean up some code quality issues 2017-12-01 22:14:06 -05:00
translators Clarify diff display of MutatingCommand 2017-10-04 16:16:45 -04:00
BackupGroupRoot.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
BUILD Add //third_party/java/jaxb dependency to targets using javax.xml.bind 2018-01-23 16:18:35 -05:00
Buildable.java Clean up some code quality issues 2017-12-01 22:14:06 -05:00
CacheUtils.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
CreateAutoTimestamp.java Add create timestamp as field on AllocationToken entity 2018-01-19 14:25:28 -05:00
EntityClasses.java Add basic AllocationToken entity and tests 2018-01-19 14:22:30 -05:00
EppResource.java Add create timestamp as field on AllocationToken entity 2018-01-19 14:25:28 -05:00
EppResourceUtils.java Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
ImmutableObject.java Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
Jsonifiable.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
JsonMapBuilder.java Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
ModelUtils.java Replace FluentIterable with streams 2017-12-27 11:40:50 -05:00
package-info.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
SchemaVersion.java Run automatic Java 8 conversion over codebase 2017-10-10 12:09:41 -04:00
UpdateAutoTimestamp.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00