mirror of
https://github.com/google/nomulus.git
synced 2025-07-23 19:20:44 +02:00
a4091594d0
We've been using the very fragile newline-delimited legacy logging
statement in FlowRunner for ICANN reporting for a long time. While
this is bad in a few ways, the worst is that the parsing of this
logging statement is extremely fragile (e.g. adding/removing fields
can easily break the parsing). This is in fact part of what broke the
ExportLogsServlet parsing last fall ([] and forced us to
recover by manually parsing the log statement (and its XML) in
BigQuery. It also broke again in [] where we were relying
on matching the logging classname, since matching on 'EPP Command'
was considered insufficiently narrow.
This introduces a new JSON-format logging statement to FlowRunner
that fixes both of these problems:
1) it replaces the newline-delimited "format" with a JSON-based
format, so that we can add new fields much more easily and
reliably support logging more structured data
2) it replaces the short 'EPP Command' signature with a much more
targeted 'EPP-REPORTING-LOG-SIGNATURE' signature so that we can
use that alone for matching, rather than relying on the class
name in the log message
What this doesn't fix is the fact that we still need to parse the
XML in BigQuery; we should fix this by logging the parts of the XML
that ICANN reporting needs explicitly, but that'll be a subsequent
change, since while the existing approach is gross, it's actually
much less fragile than just matching the log statement itself.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=125902976
|
||
|---|---|---|
| .. | ||
| async | ||
| contact | ||
| domain | ||
| host | ||
| poll | ||
| session | ||
| testdata | ||
| BUILD | ||
| CheckApiActionTest.java | ||
| EppCommitLogsTest.java | ||
| EppConsoleActionTest.java | ||
| EppControllerTest.java | ||
| EppLifecycleContactTest.java | ||
| EppLifecycleDomainApplicationTest.java | ||
| EppLifecycleDomainTest.java | ||
| EppLifecycleHostTest.java | ||
| EppLoggedOutTest.java | ||
| EppLoginAdminUserTest.java | ||
| EppLoginTlsTest.java | ||
| EppLoginUserTest.java | ||
| EppTestCase.java | ||
| EppTestComponent.java | ||
| EppTlsActionTest.java | ||
| EppToolActionTest.java | ||
| EppXmlTransformerTest.java | ||
| EppXxeAttackTest.java | ||
| FlowRunnerTest.java | ||
| FlowTestCase.java | ||
| ResourceCheckFlowTestCase.java | ||
| ResourceFlowTestCase.java | ||