mirror of
https://github.com/google/nomulus.git
synced 2025-08-04 00:42:12 +02:00
Cardinality of this metric: clientId: there are currently 650 (on sandbox, because of OTE), and 200 on production. explicitClientId: 2 roles: 2 now, might be 3 soon if we add vendors status: 2 So we're talking about a cardinality of 2,000-8,000. Less when you consider that registrars only seldom actually need to access the console (certainly not daily or even weekly). Compare with, e.g., the /epp/processing_time from the above EppMetrics.java which has: Epp commands: 26 (manual counting) client IDs: 200 on prod status: the actual status CODE of the command. Can have many values, but looking at the past few weeks' metrics I counted 20 Note that not every command results in every status. Looking a few weeks back we can see around 80-100 (commands+status) combination. buckets: 16 so that's over 250,000-1,000,000 cardinality, on a very high-volume metric. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=218699280
155 lines
6.6 KiB
Java
155 lines
6.6 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.ui.server.registrar;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.config.RegistryConfig.getDefaultRegistrarWhoisServer;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT2;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT2_HASH;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT_HASH;
|
|
import static google.registry.testing.DatastoreHelper.loadRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.util.DateTimeUtils.START_OF_TIME;
|
|
import static java.util.Arrays.asList;
|
|
|
|
import com.google.common.collect.ImmutableMap;
|
|
import google.registry.model.registrar.Registrar;
|
|
import java.util.Map;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/**
|
|
* Unit tests for security_settings.js use of {@link RegistrarSettingsAction}.
|
|
*
|
|
* <p>The default read and session validation tests are handled by the
|
|
* superclass.
|
|
*/
|
|
@RunWith(JUnit4.class)
|
|
public class SecuritySettingsTest extends RegistrarSettingsActionTestCase {
|
|
|
|
@Test
|
|
public void testPost_updateCert_success() {
|
|
Registrar modified =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT, clock.nowUtc())
|
|
.build();
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update",
|
|
"id", CLIENT_ID,
|
|
"args", modified.toJsonMap()));
|
|
// Empty whoisServer field should be set to default by server.
|
|
modified =
|
|
modified
|
|
.asBuilder()
|
|
.setWhoisServer(getDefaultRegistrarWhoisServer())
|
|
.build();
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
assertThat(response).containsEntry("results", asList(modified.toJsonMap()));
|
|
assertThat(loadRegistrar(CLIENT_ID)).isEqualTo(modified);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testPost_updateCert_failure() {
|
|
Map<String, Object> reqJson = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
reqJson.put("clientCertificate", "BLAH");
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update",
|
|
"id", CLIENT_ID,
|
|
"args", reqJson));
|
|
assertThat(response).containsEntry("status", "ERROR");
|
|
assertThat(response).containsEntry("message", "Invalid X.509 PEM certificate");
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "ERROR: FormFieldException");
|
|
}
|
|
|
|
@Test
|
|
public void testChangeCertificates() {
|
|
Map<String, Object> jsonMap = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
jsonMap.put("clientCertificate", SAMPLE_CERT);
|
|
jsonMap.put("failoverClientCertificate", null);
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getClientCertificate()).isEqualTo(SAMPLE_CERT);
|
|
assertThat(registrar.getClientCertificateHash()).isEqualTo(SAMPLE_CERT_HASH);
|
|
assertThat(registrar.getFailoverClientCertificate()).isNull();
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isNull();
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testChangeFailoverCertificate() {
|
|
Map<String, Object> jsonMap = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
jsonMap.put("failoverClientCertificate", SAMPLE_CERT2);
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getFailoverClientCertificate()).isEqualTo(SAMPLE_CERT2);
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isEqualTo(SAMPLE_CERT2_HASH);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testEmptyOrNullCertificate_doesNotClearOutCurrentOne() {
|
|
Registrar initialRegistrar =
|
|
persistResource(
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT, START_OF_TIME)
|
|
.setFailoverClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build());
|
|
Map<String, Object> jsonMap = initialRegistrar.toJsonMap();
|
|
jsonMap.put("clientCertificate", null);
|
|
jsonMap.put("failoverClientCertificate", "");
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getClientCertificate()).isEqualTo(SAMPLE_CERT);
|
|
assertThat(registrar.getClientCertificateHash()).isEqualTo(SAMPLE_CERT_HASH);
|
|
assertThat(registrar.getFailoverClientCertificate()).isEqualTo(SAMPLE_CERT2);
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isEqualTo(SAMPLE_CERT2_HASH);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testToJsonMap_containsCertificate() {
|
|
Map<String, Object> jsonMap =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build()
|
|
.toJsonMap();
|
|
assertThat(jsonMap).containsEntry("clientCertificate", SAMPLE_CERT2);
|
|
assertThat(jsonMap).containsEntry("clientCertificateHash", SAMPLE_CERT2_HASH);
|
|
}
|
|
|
|
@Test
|
|
public void testToJsonMap_containsFailoverCertificate() {
|
|
Map<String, Object> jsonMap =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setFailoverClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build()
|
|
.toJsonMap();
|
|
assertThat(jsonMap).containsEntry("failoverClientCertificate", SAMPLE_CERT2);
|
|
assertThat(jsonMap).containsEntry("failoverClientCertificateHash", SAMPLE_CERT2_HASH);
|
|
}
|
|
}
|