mirror of
https://github.com/google/nomulus.git
synced 2025-04-29 19:47:51 +02:00
959c7f7899
* Enhance the test for forbidden Schema changes Current test is git-based. It is difficult to maintain and does not catch out-of-order version numbers. It is also more aggressive than necessary, failing on changes to submitted scripts that have not been deployed yet. The new test starts a database, deploys the current schema to it, then deploys the set of Flyway scripts in this repository to the database.
79 lines
3 KiB
Bash
Executable file
79 lines
3 KiB
Bash
Executable file
#!/bin/bash
|
|
# Copyright 2020 The Nomulus Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
# This script runs the sqlIntegrationTestSuite in a given server release
|
|
# against a specific Cloud SQL schema release. When invoked during presubmit
|
|
# tests, it detects code or schema changes that are incompatible with current
|
|
# deployments in production.
|
|
|
|
USAGE="
|
|
$(basename "$0") [--help]
|
|
or
|
|
$(basename "$0") OPTIONS
|
|
Checks for post-deployment change to Flyway scripts.
|
|
|
|
With Flyway, once an incremental change script is deployed, it must not be
|
|
edited, renamed, or deleted. This script checks for changes to scripts that have
|
|
already been deployed to Sandbox. The assumption is that the schema in Sandbox
|
|
is always at least as recent as that in production. Please refer to Gradle task
|
|
:db:schemaIncrementalDeployTest for more information.
|
|
|
|
Note that this test MAY fail to catch forbidden changes during the period when
|
|
a new schema release is created but not yet deployed to Sandbox.
|
|
|
|
A side-effect of this check is that old branches missing recently deployed
|
|
scripts must update first.
|
|
|
|
Options:
|
|
-h, --help show this help text
|
|
-p, --project
|
|
the GCP project with deployment infrastructure. It should
|
|
take the devProject property defined in the Gradle root
|
|
project."
|
|
|
|
SCRIPT_DIR="$(realpath $(dirname $0))"
|
|
|
|
. "${SCRIPT_DIR}/testutils_bashrc"
|
|
|
|
set -e
|
|
|
|
eval set -- $(getopt -o p:s:e:h -l project:,sut:,env:,help -- "$@")
|
|
while true; do
|
|
case "$1" in
|
|
-p | --project) DEV_PROJECT="$2"; shift 2 ;;
|
|
-h | --help) echo "${USAGE}"; exit 0 ;;
|
|
--) shift; break ;;
|
|
*) echo "${USAGE}"; exit 1 ;;
|
|
esac
|
|
done
|
|
|
|
if [[ -z "${DEV_PROJECT}" ]]; then
|
|
echo "${USAGE}"
|
|
exit 1
|
|
fi
|
|
|
|
sandbox_tag=$(fetchVersion sql sandbox ${DEV_PROJECT})
|
|
echo "Checking Flyway scripts against schema in Sandbox (${sandbox_tag})."
|
|
|
|
# The URL of the Maven repo on GCS for the publish_repo parameter must use the
|
|
# https scheme (https://storage.googleapis.com/{BUCKET}/{PATH}) in order to work
|
|
# with Kokoro. Gradle's alternative gcs scheme does not work on Kokoro: a GCP
|
|
# credential with proper scopes for GCS access is required even for public
|
|
# buckets, however, Kokoro VM instances are not set up with such credentials.
|
|
# Incidentally, gcs can be used on Cloud Build.
|
|
(cd ${SCRIPT_DIR}/..; \
|
|
./gradlew :db:schemaIncrementalDeployTest \
|
|
-PbaseSchemaTag=${sandbox_tag} \
|
|
-Ppublish_repo=https://storage.googleapis.com/${DEV_PROJECT}-deployed-tags/maven)
|