mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 20:47:52 +02:00
9122372e38
This change moves the reflective setAccessible() calls on the request component methods (needed so that they can be invoked reflectively from RequestHandler) to within Router itself, eliminating the need to manually call this from each Servlet class and then pass in the resulting Method objects. Instead, we just pass in the request component class and let Router do the rest. Old comments say that cross-package reflection is not allowed on AppEngine, but while it's quite possible this was once the case, I can't reproduce that limitation, and the documentation seems to contradict any such restriction: """ An application is allowed full, unrestricted, reflective access to its own classes. It can query any private members, call the method java.lang.reflect.AccessibleObject.setAccessible(), and read/set private members. """ https://cloud.google.com/appengine/docs/java/runtime#reflection ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=138693006
43 lines
1.6 KiB
Java
43 lines
1.6 KiB
Java
// Copyright 2016 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.module.tools;
|
|
|
|
import google.registry.request.RequestHandler;
|
|
import google.registry.request.RequestModule;
|
|
import java.io.IOException;
|
|
import java.security.Security;
|
|
import javax.servlet.http.HttpServlet;
|
|
import javax.servlet.http.HttpServletRequest;
|
|
import javax.servlet.http.HttpServletResponse;
|
|
import org.bouncycastle.jce.provider.BouncyCastleProvider;
|
|
|
|
/** Servlet that should handle all requests to our "tools" App Engine module. */
|
|
public final class ToolsServlet extends HttpServlet {
|
|
|
|
private static final ToolsComponent component = DaggerToolsComponent.create();
|
|
|
|
private static final RequestHandler<ToolsRequestComponent> requestHandler =
|
|
RequestHandler.create(ToolsRequestComponent.class);
|
|
|
|
@Override
|
|
public void init() {
|
|
Security.addProvider(new BouncyCastleProvider());
|
|
}
|
|
|
|
@Override
|
|
public void service(HttpServletRequest req, HttpServletResponse rsp) throws IOException {
|
|
requestHandler.handleRequest(req, rsp, component.startRequest(new RequestModule(req, rsp)));
|
|
}
|
|
}
|