mirror of
https://github.com/google/nomulus.git
synced 2025-05-03 21:47:51 +02:00
81dc2bbbc3
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
48 lines
1.7 KiB
Java
48 lines
1.7 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.reporting;
|
|
|
|
import google.registry.config.RegistryConfig.Config;
|
|
import google.registry.util.FormattingLogger;
|
|
import google.registry.util.SendEmailService;
|
|
import javax.inject.Inject;
|
|
import javax.mail.Message;
|
|
import javax.mail.Message.RecipientType;
|
|
import javax.mail.internet.InternetAddress;
|
|
|
|
/** Static utils for emailing reporting results. */
|
|
public class ReportingEmailUtils {
|
|
|
|
@Inject @Config("alertSenderEmailAddress") String sender;
|
|
@Inject @Config("alertRecipientEmailAddress") String recipient;
|
|
@Inject SendEmailService emailService;
|
|
@Inject ReportingEmailUtils() {}
|
|
|
|
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
|
|
|
|
void emailResults(String subject, String body) {
|
|
try {
|
|
Message msg = emailService.createMessage();
|
|
logger.infofmt("Emailing %s", recipient);
|
|
msg.setFrom(new InternetAddress(sender));
|
|
msg.addRecipient(RecipientType.TO, new InternetAddress(recipient));
|
|
msg.setSubject(subject);
|
|
msg.setText(body);
|
|
emailService.sendMessage(msg);
|
|
} catch (Exception e) {
|
|
logger.warning(e, "E-mail service failed.");
|
|
}
|
|
}
|
|
}
|