nickfelt 7e68ffa16a Change transfer flow tests to assert on entire TransferData contents ... This CL changes the domain and contact transfer flows to check the entire TransferData on the post-transfer resource, rather than just spot-checking certain fields. This approach provides much better code coverage - in particular, it checks that the non-request flows (approve, cancel, reject) don't modify the fields that they shouldn't be modifying, and that they do actually clear out the transfer server-approve entities fields written by the transfer request flow. It's slightly orthogonal, but I also added testing that the server-approve entities fields are actually set in the request flows, which was previously untested. This is pre-work for introducing an exDate-storing field into TransferData, by making it easier to test everywhere that exDate is set *and* unset only in the correct places. As part of this CL, I've introduced a TransferData.copyConstantFieldsToBuilder() method that is like asBuilder() but instead of copying all the fields to the new builder, it only copies the logically constant ones: losing/gaining client IDs, the request time and TRID, and transferPeriod. This is useful both in tests but is also used in the resolvingPendingTransfer() helper that centralizes the core transfer resolution logic (as of [] That method has its own tests, and in the process I removed a bunch of crufty defunct TransferData tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171053454		2017-10-05 11:44:46 -04:00
..
billing	Make Registrar load methods return Optionals instead of Nullables	2017-08-01 16:58:59 -04:00
common	Remove long-dead LogsExportCursor and PersistedRangeLong	2017-09-20 10:27:17 -04:00
contact	Refactor out creation of server TRIDs so they can be tested	2017-04-13 10:55:47 -04:00
domain	Remove temporary @OnLoad used for setting period in DomainApplication	2017-06-21 09:51:28 -04:00
eppinput	Add and adjust EppInput accessors for more useful properties	2017-04-26 10:51:47 -04:00
eppoutput	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
host	Refactor out creation of server TRIDs so they can be tested	2017-04-13 10:55:47 -04:00
index	Finalize local variable to fix kokoro	2017-10-04 16:16:44 -04:00
mark	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
ofy	Add test for wrong bucketId order in CommitLogCheckpoint.create	2017-08-29 15:49:14 -04:00
poll	Refactor out creation of server TRIDs so they can be tested	2017-04-13 10:55:47 -04:00
rde	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
registrar	Make Registrar load methods return Optionals instead of Nullables	2017-08-01 16:58:59 -04:00
registry	Refector metrics truth subject	2017-10-04 16:16:45 -04:00
reporting	Unnest transactionFieldAmount from DomainTransactionRecord	2017-08-29 17:05:15 -04:00
server	Check if lock owner is finished on lock acquisition	2017-09-20 10:27:17 -04:00
smd	Refer to Datastore everywhere correctly by its capitalized form	2017-02-17 12:12:12 -05:00
tmch	Perform some minor test cleanup	2017-08-01 16:20:49 -04:00
transfer	Change transfer flow tests to assert on entire TransferData contents	2017-10-05 11:44:46 -04:00
translators	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
BUILD	Check if lock owner is finished on lock acquisition	2017-09-20 10:27:17 -04:00
CreateAutoTimestampTest.java	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
EntityClassesTest.java	Fix mismatch in types of Predicates being used	2017-10-04 16:16:45 -04:00
EntityTestCase.java	Refer to Datastore everywhere correctly by its capitalized form	2017-02-17 12:12:12 -05:00
EppResourceUtilsTest.java	Remove the ofy().load() inside of HostResource.cloneProjectedAtTime	2017-03-13 11:22:55 -04:00
ImmutableObjectTest.java	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
ModelUtilsTest.java	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
ResourceCommandTestCase.java	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
schema.txt	Remove schema-foss.txt	2017-10-04 16:16:45 -04:00
SchemaVersionTest.java	Add golden files for request component routing maps	2017-06-05 18:17:09 -04:00
UpdateAutoTimestampTest.java	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00