mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 04:27:51 +02:00
This CL changes the domain and contact transfer flows to check the entire TransferData on the post-transfer resource, rather than just spot-checking certain fields. This approach provides much better code coverage - in particular, it checks that the non-request flows (approve, cancel, reject) don't modify the fields that they shouldn't be modifying, and that they do actually clear out the transfer server-approve entities fields written by the transfer request flow. It's slightly orthogonal, but I also added testing that the server-approve entities fields are actually set in the request flows, which was previously untested. This is pre-work for introducing an exDate-storing field into TransferData, by making it easier to test everywhere that exDate is set *and* unset only in the correct places. As part of this CL, I've introduced a TransferData.copyConstantFieldsToBuilder() method that is like asBuilder() but instead of copying all the fields to the new builder, it only copies the logically constant ones: losing/gaining client IDs, the request time and TRID, and transferPeriod. This is useful both in tests but is also used in the resolvingPendingTransfer() helper that centralizes the core transfer resolution logic (as of [] That method has its own tests, and in the process I removed a bunch of crufty defunct TransferData tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171053454
342 lines
14 KiB
Java
342 lines
14 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.flows.domain;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.reporting.DomainTransactionRecord.TransactionReportField.NET_RENEWS_3_YR;
|
|
import static google.registry.model.reporting.DomainTransactionRecord.TransactionReportField.TRANSFER_NACKED;
|
|
import static google.registry.model.reporting.DomainTransactionRecord.TransactionReportField.TRANSFER_SUCCESSFUL;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_CREATE;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_TRANSFER_REJECT;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_TRANSFER_REQUEST;
|
|
import static google.registry.testing.DatastoreHelper.assertBillingEvents;
|
|
import static google.registry.testing.DatastoreHelper.deleteResource;
|
|
import static google.registry.testing.DatastoreHelper.getOnlyHistoryEntryOfType;
|
|
import static google.registry.testing.DatastoreHelper.getOnlyPollMessage;
|
|
import static google.registry.testing.DatastoreHelper.getPollMessages;
|
|
import static google.registry.testing.DatastoreHelper.loadRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.DomainResourceSubject.assertAboutDomains;
|
|
import static google.registry.testing.HistoryEntrySubject.assertAboutHistoryEntries;
|
|
import static google.registry.util.DateTimeUtils.END_OF_TIME;
|
|
|
|
import com.google.common.collect.FluentIterable;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.google.common.collect.Iterables;
|
|
import google.registry.flows.ResourceFlowUtils.BadAuthInfoForResourceException;
|
|
import google.registry.flows.ResourceFlowUtils.ResourceDoesNotExistException;
|
|
import google.registry.flows.ResourceFlowUtils.ResourceNotOwnedException;
|
|
import google.registry.flows.domain.DomainFlowUtils.NotAuthorizedForTldException;
|
|
import google.registry.flows.exceptions.NotPendingTransferException;
|
|
import google.registry.model.contact.ContactAuthInfo;
|
|
import google.registry.model.domain.DomainAuthInfo;
|
|
import google.registry.model.domain.DomainResource;
|
|
import google.registry.model.domain.GracePeriod;
|
|
import google.registry.model.eppcommon.AuthInfo.PasswordAuth;
|
|
import google.registry.model.eppcommon.Trid;
|
|
import google.registry.model.poll.PendingActionNotificationResponse;
|
|
import google.registry.model.poll.PollMessage;
|
|
import google.registry.model.registry.Registry;
|
|
import google.registry.model.reporting.DomainTransactionRecord;
|
|
import google.registry.model.reporting.HistoryEntry;
|
|
import google.registry.model.transfer.TransferData;
|
|
import google.registry.model.transfer.TransferResponse;
|
|
import google.registry.model.transfer.TransferStatus;
|
|
import org.joda.time.DateTime;
|
|
import org.joda.time.Duration;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link DomainTransferRejectFlow}. */
|
|
public class DomainTransferRejectFlowTest
|
|
extends DomainTransferFlowTestCase<DomainTransferRejectFlow, DomainResource> {
|
|
|
|
@Before
|
|
public void setUp() throws Exception {
|
|
setEppInput("domain_transfer_reject.xml");
|
|
setClientIdForFlow("TheRegistrar");
|
|
setupDomainWithPendingTransfer("example", "tld");
|
|
clock.advanceOneMilli();
|
|
}
|
|
|
|
private void doSuccessfulTest(String commandFilename, String expectedXmlFilename)
|
|
throws Exception {
|
|
setEppInput(commandFilename);
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
// Make sure the implicit billing event is there; it will be deleted by the flow.
|
|
// We also expect to see autorenew events for the gaining and losing registrars.
|
|
assertBillingEvents(
|
|
getBillingEventForImplicitTransfer(),
|
|
getGainingClientAutorenewEvent(),
|
|
getLosingClientAutorenewEvent());
|
|
// Look in the future and make sure the poll messages for implicit ack are there.
|
|
assertThat(getPollMessages("NewRegistrar", clock.nowUtc().plusMonths(1)))
|
|
.hasSize(1);
|
|
assertThat(getPollMessages("TheRegistrar", clock.nowUtc().plusMonths(1)))
|
|
.hasSize(1);
|
|
// Setup done; run the test.
|
|
assertTransactionalFlow(true);
|
|
DateTime originalExpirationTime = domain.getRegistrationExpirationTime();
|
|
ImmutableSet<GracePeriod> originalGracePeriods = domain.getGracePeriods();
|
|
TransferData originalTransferData = domain.getTransferData();
|
|
runFlowAssertResponse(readFile(expectedXmlFilename));
|
|
// Transfer should have been rejected. Verify correct fields were set.
|
|
domain = reloadResourceByForeignKey();
|
|
assertTransferFailed(domain, TransferStatus.CLIENT_REJECTED, originalTransferData);
|
|
assertAboutDomains().that(domain)
|
|
.hasRegistrationExpirationTime(originalExpirationTime).and()
|
|
.hasLastTransferTimeNotEqualTo(clock.nowUtc()).and()
|
|
.hasOneHistoryEntryEachOfTypes(
|
|
DOMAIN_CREATE, DOMAIN_TRANSFER_REQUEST, DOMAIN_TRANSFER_REJECT);
|
|
final HistoryEntry historyEntryTransferRejected =
|
|
getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_REJECT);
|
|
assertAboutHistoryEntries()
|
|
.that(historyEntryTransferRejected)
|
|
.hasOtherClientId("NewRegistrar");
|
|
// The only billing event left should be the original autorenew event, now reopened.
|
|
assertBillingEvents(
|
|
getLosingClientAutorenewEvent().asBuilder().setRecurrenceEndTime(END_OF_TIME).build());
|
|
// The poll message (in the future) to the losing registrar for implicit ack should be gone.
|
|
assertThat(getPollMessages("TheRegistrar", clock.nowUtc().plusMonths(1)))
|
|
.isEmpty();
|
|
// The poll message in the future to the gaining registrar should be gone too, but there
|
|
// should be one at the current time to the gaining registrar.
|
|
PollMessage gainingPollMessage = getOnlyPollMessage("NewRegistrar");
|
|
assertThat(gainingPollMessage.getEventTime()).isEqualTo(clock.nowUtc());
|
|
assertThat(
|
|
Iterables.getOnlyElement(FluentIterable
|
|
.from(gainingPollMessage.getResponseData())
|
|
.filter(TransferResponse.class))
|
|
.getTransferStatus())
|
|
.isEqualTo(TransferStatus.CLIENT_REJECTED);
|
|
PendingActionNotificationResponse panData = Iterables.getOnlyElement(FluentIterable
|
|
.from(gainingPollMessage.getResponseData())
|
|
.filter(PendingActionNotificationResponse.class));
|
|
assertThat(panData.getTrid())
|
|
.isEqualTo(Trid.create("transferClient-trid", "transferServer-trid"));
|
|
assertThat(panData.getActionResult()).isFalse();
|
|
// The original grace periods should remain untouched.
|
|
assertThat(domain.getGracePeriods()).isEqualTo(originalGracePeriods);
|
|
}
|
|
|
|
private void doFailingTest(String commandFilename) throws Exception {
|
|
setEppInput(commandFilename);
|
|
// Replace the ROID in the xml file with the one generated in our test.
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
// Setup done; run the test.
|
|
assertTransactionalFlow(true);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess() throws Exception {
|
|
doSuccessfulTest("domain_transfer_reject.xml", "domain_transfer_reject_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testDryRun() throws Exception {
|
|
setEppInput("domain_transfer_reject.xml");
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
dryRunFlowAssertResponse(readFile("domain_transfer_reject_response.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_domainAuthInfo() throws Exception {
|
|
doSuccessfulTest("domain_transfer_reject_domain_authinfo.xml",
|
|
"domain_transfer_reject_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_contactAuthInfo() throws Exception {
|
|
doSuccessfulTest("domain_transfer_reject_contact_authinfo.xml",
|
|
"domain_transfer_reject_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_notAuthorizedForTld() throws Exception {
|
|
persistResource(
|
|
loadRegistrar("TheRegistrar")
|
|
.asBuilder()
|
|
.setAllowedTlds(ImmutableSet.<String>of())
|
|
.build());
|
|
thrown.expect(NotAuthorizedForTldException.class);
|
|
doSuccessfulTest("domain_transfer_reject.xml", "domain_transfer_reject_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_superuserNotAuthorizedForTld() throws Exception {
|
|
persistResource(
|
|
loadRegistrar("TheRegistrar")
|
|
.asBuilder()
|
|
.setAllowedTlds(ImmutableSet.<String>of())
|
|
.build());
|
|
runFlowAssertResponse(
|
|
CommitMode.LIVE,
|
|
UserPrivileges.SUPERUSER,
|
|
readFile("domain_transfer_reject_response.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_badContactPassword() throws Exception {
|
|
// Change the contact's password so it does not match the password in the file.
|
|
contact = persistResource(
|
|
contact.asBuilder()
|
|
.setAuthInfo(ContactAuthInfo.create(PasswordAuth.create("badpassword")))
|
|
.build());
|
|
thrown.expect(BadAuthInfoForResourceException.class);
|
|
doFailingTest("domain_transfer_reject_contact_authinfo.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_badDomainPassword() throws Exception {
|
|
// Change the domain's password so it does not match the password in the file.
|
|
domain = persistResource(
|
|
domain.asBuilder()
|
|
.setAuthInfo(DomainAuthInfo.create(PasswordAuth.create("badpassword")))
|
|
.build());
|
|
thrown.expect(BadAuthInfoForResourceException.class);
|
|
doFailingTest("domain_transfer_reject_domain_authinfo.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_neverBeenTransferred() throws Exception {
|
|
changeTransferStatus(null);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientApproved() throws Exception {
|
|
changeTransferStatus(TransferStatus.CLIENT_APPROVED);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientRejected() throws Exception {
|
|
changeTransferStatus(TransferStatus.CLIENT_REJECTED);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientCancelled() throws Exception {
|
|
changeTransferStatus(TransferStatus.CLIENT_CANCELLED);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_serverApproved() throws Exception {
|
|
changeTransferStatus(TransferStatus.SERVER_APPROVED);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_serverCancelled() throws Exception {
|
|
changeTransferStatus(TransferStatus.SERVER_CANCELLED);
|
|
thrown.expect(NotPendingTransferException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_gainingClient() throws Exception {
|
|
setClientIdForFlow("NewRegistrar");
|
|
thrown.expect(ResourceNotOwnedException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_unrelatedClient() throws Exception {
|
|
setClientIdForFlow("ClientZ");
|
|
thrown.expect(ResourceNotOwnedException.class);
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_deletedDomain() throws Exception {
|
|
domain = persistResource(
|
|
domain.asBuilder().setDeletionTime(clock.nowUtc().minusDays(1)).build());
|
|
thrown.expect(
|
|
ResourceDoesNotExistException.class,
|
|
String.format("(%s)", getUniqueIdFromCommand()));
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_nonexistentDomain() throws Exception {
|
|
deleteResource(domain);
|
|
thrown.expect(
|
|
ResourceDoesNotExistException.class,
|
|
String.format("(%s)", getUniqueIdFromCommand()));
|
|
doFailingTest("domain_transfer_reject.xml");
|
|
}
|
|
|
|
// NB: No need to test pending delete status since pending transfers will get cancelled upon
|
|
// entering pending delete phase. So it's already handled in that test case.
|
|
|
|
@Test
|
|
public void testIcannActivityReportField_getsLogged() throws Exception {
|
|
runFlow();
|
|
assertIcannReportingActivityFieldLogged("srs-dom-transfer-reject");
|
|
assertTldsFieldLogged("tld");
|
|
}
|
|
|
|
private void setUpGracePeriodDurations() {
|
|
persistResource(
|
|
Registry.get("tld")
|
|
.asBuilder()
|
|
.setAutomaticTransferLength(Duration.standardDays(2))
|
|
.setTransferGracePeriodLength(Duration.standardDays(3))
|
|
.build());
|
|
}
|
|
|
|
@Test
|
|
public void testIcannTransactionRecord_noRecordsToCancel() throws Exception {
|
|
setUpGracePeriodDurations();
|
|
runFlow();
|
|
HistoryEntry persistedEntry = getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_REJECT);
|
|
// We should only produce transfer nacked records, reported now
|
|
assertThat(persistedEntry.getDomainTransactionRecords())
|
|
.containsExactly(DomainTransactionRecord.create("tld", clock.nowUtc(), TRANSFER_NACKED, 1));
|
|
}
|
|
|
|
@Test
|
|
public void testIcannTransactionRecord_cancelsPreviousRecords() throws Exception {
|
|
setUpGracePeriodDurations();
|
|
DomainTransactionRecord previousSuccessRecord =
|
|
DomainTransactionRecord.create(
|
|
"tld", clock.nowUtc().plusDays(1), TRANSFER_SUCCESSFUL, 1);
|
|
// We only want to cancel TRANSFER_SUCCESSFUL records
|
|
DomainTransactionRecord notCancellableRecord =
|
|
DomainTransactionRecord.create("tld", clock.nowUtc().plusDays(1), NET_RENEWS_3_YR, 5);
|
|
persistResource(
|
|
new HistoryEntry.Builder()
|
|
.setType(DOMAIN_TRANSFER_REQUEST)
|
|
.setParent(domain)
|
|
.setModificationTime(clock.nowUtc().minusDays(4))
|
|
.setDomainTransactionRecords(
|
|
ImmutableSet.of(previousSuccessRecord, notCancellableRecord))
|
|
.build());
|
|
runFlow();
|
|
HistoryEntry persistedEntry = getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_REJECT);
|
|
// We should only produce cancellation records for the original success records and nack records
|
|
assertThat(persistedEntry.getDomainTransactionRecords())
|
|
.containsExactly(
|
|
previousSuccessRecord.asBuilder().setReportAmount(-1).build(),
|
|
DomainTransactionRecord.create("tld", clock.nowUtc(), TRANSFER_NACKED, 1));
|
|
}
|
|
}
|