mirror of
https://github.com/google/nomulus.git
synced 2025-05-05 06:27:51 +02:00
7e68ffa16a
This CL changes the domain and contact transfer flows to check the entire TransferData on the post-transfer resource, rather than just spot-checking certain fields. This approach provides much better code coverage - in particular, it checks that the non-request flows (approve, cancel, reject) don't modify the fields that they shouldn't be modifying, and that they do actually clear out the transfer server-approve entities fields written by the transfer request flow. It's slightly orthogonal, but I also added testing that the server-approve entities fields are actually set in the request flows, which was previously untested. This is pre-work for introducing an exDate-storing field into TransferData, by making it easier to test everywhere that exDate is set *and* unset only in the correct places. As part of this CL, I've introduced a TransferData.copyConstantFieldsToBuilder() method that is like asBuilder() but instead of copying all the fields to the new builder, it only copies the logically constant ones: losing/gaining client IDs, the request time and TRID, and transferPeriod. This is useful both in tests but is also used in the resolvingPendingTransfer() helper that centralizes the core transfer resolution logic (as of [] That method has its own tests, and in the process I removed a bunch of crufty defunct TransferData tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171053454 |
||
|---|---|---|
| .. | ||
| BUILD | ||
| DeleteContactsAndHostsActionTest.java | ||
| DeleteProberDataActionTest.java | ||
| ExpandRecurringBillingEventsActionTest.java | ||
| MapreduceEntityCleanupActionTest.java | ||
| RefreshDnsOnHostRenameActionTest.java | ||
| ResaveAllEppResourcesActionTest.java | ||
| TestMapreduceEntityCleanupUtil.java | ||
| VerifyEntityIntegrityActionTest.java | ||