zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-08-03 16:32:11 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/flows
History
cgoldfeder 75d9268ecd Resolve an old TODO by doing nothing 
The RFCs are ambiguous.

5733 (contacts):

3.2.4.  EPP <transfer> Command

   ...the
   <transfer> command MUST contain a <contact:transfer> element that
   identifies the contact namespace.  The <contact:transfer> element
   contains the following child elements:

    ...

   -  A <contact:authInfo> element that contains authorization
      information associated with the contact object.

However, the xsd explicitly marks it as optional:

    <complexType name="authIDType">
      <sequence>
        <element name="id" type="eppcom:clIDType"/>
        <element name="authInfo" type="contact:authInfoType"
         minOccurs="0"/>
      </sequence>
    </complexType>

The language in 5731 (domains) is [] The only example given in both is for a transfer request, which is the one flow that obviously requires the authInfo.

We had decided that for transfer approve and reject, which are done by the losing client, requiring the authInfo is silly because it's available to that registrar from an <info> and there's no extra security in having them present it (although if they do present it we validate it). The question about cancel was whether the gaining client, which had to present the authInfo in the original transfer request, needs it again for cancel.

I can't come up with any reason this would be beneficial, and I'm making the decision: authInfo is not required on transfer cancel.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=133168739
2016-09-19 11:46:14 -04:00
..
async DeReference the codebase 2016-09-02 13:50:20 -04:00
contact Resolve an old TODO by doing nothing 2016-09-19 11:46:14 -04:00
domain Simplify the use of the fee extension a little 2016-09-14 16:11:56 -04:00
exceptions Duplicate EppExceptions outside of the flow hierarchy 2016-09-14 15:54:15 -04:00
host DeReference the codebase 2016-09-02 13:50:20 -04:00
picker Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
poll Handle nullness properly in some message/flow/poll code 2016-07-15 14:58:57 -04:00
session Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
soy Add --set_current_tld_state to UpdateTldCommand 2016-08-02 19:02:19 -04:00
BUILD Add EPP metrics to flows 2016-09-14 15:32:27 -04:00
CheckApiAction.java Support version 0.12 of the EPP Fee Extension 2016-07-21 14:55:08 -04:00
EppConsoleAction.java Decouple GaeUserCredentials from UserService and simplify tests 2016-09-14 15:36:53 -04:00
EppController.java Change EppMetric.Builder to use @AutoValue.Builder 2016-09-14 15:38:22 -04:00
EppException.java Fix copy/paste javadoc erroc 2016-09-14 15:41:32 -04:00
EppMetrics.java Add EPP metrics to flows 2016-09-14 15:32:27 -04:00
EppRequestHandler.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppRequestSource.java Break SessionSource out of SessionMetadata and rename it EppRequestSource. 2016-06-27 16:19:21 -04:00
EppTlsAction.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppToolAction.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppXmlTransformer.java Add XML support for new Flags EPP extension 2016-08-02 19:03:26 -04:00
Flow.java Support multiple versions of the EPP Fee Extension 2016-07-21 14:53:50 -04:00
FlowComponent.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FlowModule.java Inject targetId into contact flows 2016-09-14 16:37:36 -04:00
FlowRunner.java Get rid of @Nullable on the injected client id 2016-09-14 16:08:38 -04:00
FlowScope.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GaeUserCredentials.java Decouple GaeUserCredentials from UserService and simplify tests 2016-09-14 15:36:53 -04:00
HttpSessionMetadata.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
LoggedInFlow.java Log the class names of unimplemented extensions before 2016-09-14 15:42:59 -04:00
OwnedResourceMutateFlow.java Decouple superuser from SessionMetadata 2016-06-27 16:17:57 -04:00
OwnedResourceMutatePendingTransferFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
PasswordOnlyTransportCredentials.java Refactor SessionMetadata and TransportCredentials toString() methods 2016-06-27 16:43:12 -04:00
ResourceAsyncDeleteFlow.java DeReference the codebase 2016-09-02 13:50:20 -04:00
ResourceCheckFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceCreateFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceCreateOrMutateFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceDeleteFlow.java Handle nullness properly in some message/flow/poll code 2016-07-15 14:58:57 -04:00
ResourceFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceFlowUtils.java Crush out shared code in contact flows, especially transfer 2016-09-14 16:10:18 -04:00
ResourceInfoFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceMutateFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ResourceMutatePendingTransferFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ResourceQueryFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ResourceSyncDeleteFlow.java Add extra logic for all relevant flows 2016-09-14 15:26:36 -04:00
ResourceTransferApproveFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceTransferCancelFlow.java Resolve an old TODO by doing nothing 2016-09-19 11:46:14 -04:00
ResourceTransferFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ResourceTransferQueryFlow.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ResourceTransferRejectFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ResourceTransferRequestFlow.java Add extra logic for all relevant flows 2016-09-14 15:26:36 -04:00
ResourceUpdateFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
SessionMetadata.java Refactor SessionMetadata and TransportCredentials toString() methods 2016-06-27 16:43:12 -04:00
SingleResourceFlow.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
StatelessRequestSessionMetadata.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
TlsCredentials.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
TransactionalFlow.java Make javadoc <p> style guide compliant 2016-05-18 13:09:01 -04:00
TransportCredentials.java Decouple SessionMetadata and TransportCredentials 2016-06-27 16:14:57 -04:00