google-nomulus/java/google/registry/model/reporting/HistoryEntry.java
cgoldfeder 5098b03af4 DeReference the codebase
This change replaces all Ref objects in the code with Key objects. These are
stored in datastore as the same object (raw datastore keys), so this is not
a model change.

Our best practices doc says to use Keys not Refs because:
 * The .get() method obscures what's actually going on
   - Much harder to visually audit the code for datastore loads
   - Hard to distinguish Ref<T> get()'s from Optional get()'s and Supplier get()'s
 * Implicit ofy().load() offers much less control
   - Antipattern for ultimate goal of making Ofy injectable
   - Can't control cache use or batch loading without making ofy() explicit anyway
 * Serialization behavior is surprising and could be quite dangerous/incorrect
   - Can lead to serialization errors. If it actually worked "as intended",
     it would lead to a Ref<> on a serialized object being replaced upon
     deserialization with a stale copy of the old value, which could potentially
     break all kinds of transactional expectations
 * Having both Ref<T> and Key<T> introduces extra boilerplate everywhere
   - E.g. helper methods all need to have Ref and Key overloads, or you need to
     call .key() to get the Key<T> for every Ref<T> you want to pass in
   - Creating a Ref<T> is more cumbersome, since it doesn't have all the create()
     overloads that Key<T> has, only create(Key<T>) and create(Entity) - no way to
     create directly from kind+ID/name, raw Key, websafe key string, etc.

(Note that Refs are treated specially by Objectify's @Load method and Keys are not;
we don't use that feature, but it is the one advantage Refs have over Keys.)

The direct impetus for this change is that I am trying to audit our use of memcache,
and the implicit .get() calls to datastore were making that very hard.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131965491
2016-09-02 13:50:20 -04:00

224 lines
5.7 KiB
Java

// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.model.reporting;
import com.googlecode.objectify.Key;
import com.googlecode.objectify.annotation.Entity;
import com.googlecode.objectify.annotation.Id;
import com.googlecode.objectify.annotation.IgnoreSave;
import com.googlecode.objectify.annotation.Index;
import com.googlecode.objectify.annotation.Parent;
import com.googlecode.objectify.condition.IfNull;
import google.registry.model.Buildable;
import google.registry.model.EppResource;
import google.registry.model.ImmutableObject;
import google.registry.model.ImmutableObject.DoNotHydrate;
import google.registry.model.domain.Period;
import google.registry.model.eppcommon.Trid;
import org.joda.time.DateTime;
/** A record of an EPP command that mutated a resource. */
@Entity
@DoNotHydrate
public class HistoryEntry extends ImmutableObject implements Buildable {
/** Represents the type of history entry. */
public enum Type {
CONTACT_CREATE,
CONTACT_DELETE,
CONTACT_DELETE_FAILURE,
CONTACT_PENDING_DELETE,
CONTACT_TRANSFER_APPROVE,
CONTACT_TRANSFER_CANCEL,
CONTACT_TRANSFER_REJECT,
CONTACT_TRANSFER_REQUEST,
CONTACT_UPDATE,
DOMAIN_ALLOCATE,
DOMAIN_APPLICATION_CREATE,
DOMAIN_APPLICATION_DELETE,
DOMAIN_APPLICATION_UPDATE,
DOMAIN_APPLICATION_STATUS_UPDATE,
DOMAIN_CREATE,
DOMAIN_DELETE,
DOMAIN_RENEW,
DOMAIN_RESTORE,
DOMAIN_TRANSFER_APPROVE,
DOMAIN_TRANSFER_CANCEL,
DOMAIN_TRANSFER_REJECT,
DOMAIN_TRANSFER_REQUEST,
DOMAIN_UPDATE,
HOST_CREATE,
HOST_DELETE,
HOST_DELETE_FAILURE,
HOST_PENDING_DELETE,
HOST_UPDATE,
/**
* A synthetic history entry created by a tool or back-end migration script outside of the scope
* of usual EPP flows. These are sometimes needed to serve as parents for billing events or poll
* messages that otherwise wouldn't have a suitable parent.
*/
SYNTHETIC
}
/** The autogenerated id of this event. */
@Id
long id;
/** The resource this event mutated. */
@Parent
Key<? extends EppResource> parent;
/** The type of history entry. */
Type type;
/**
* The length of time that a create, allocate, renewal, or transfer request was issued for. Will
* be null for all other types.
*/
@IgnoreSave(IfNull.class)
Period period;
/** The actual EPP xml of the command, stored as bytes to be agnostic of encoding. */
byte[] xmlBytes;
/** The time the command occurred. */
@Index
DateTime modificationTime;
/** The id of the registrar that sent the command. */
@Index
String clientId;
/** Transaction id that made this change. */
Trid trid;
/** Whether this change was created by a superuser. */
boolean bySuperuser;
/** Reason for the change. */
String reason;
/** Whether this change was requested by a registrar. */
Boolean requestedByRegistrar;
public Key<? extends EppResource> getParent() {
return parent;
}
public Type getType() {
return type;
}
public Period getPeriod() {
return period;
}
public byte[] getXmlBytes() {
return xmlBytes;
}
public DateTime getModificationTime() {
return modificationTime;
}
public String getClientId() {
return clientId;
}
public Trid getTrid() {
return trid;
}
public boolean getBySuperuser() {
return bySuperuser;
}
public String getReason() {
return reason;
}
public Boolean getRequestedByRegistrar() {
return requestedByRegistrar;
}
@Override
public Builder asBuilder() {
return new Builder(clone(this));
}
/** A builder for {@link HistoryEntry} since it is immutable */
public static class Builder extends Buildable.Builder<HistoryEntry> {
public Builder() {}
public Builder(HistoryEntry instance) {
super(instance);
}
public Builder setParent(EppResource parent) {
getInstance().parent = Key.create(parent);
return this;
}
public Builder setParent(Key<? extends EppResource> parentKey) {
getInstance().parent = parentKey;
return this;
}
public Builder setType(Type type) {
getInstance().type = type;
return this;
}
public Builder setPeriod(Period period) {
getInstance().period = period;
return this;
}
public Builder setXmlBytes(byte[] xmlBytes) {
getInstance().xmlBytes = xmlBytes;
return this;
}
public Builder setModificationTime(DateTime modificationTime) {
getInstance().modificationTime = modificationTime;
return this;
}
public Builder setClientId(String clientId) {
getInstance().clientId = clientId;
return this;
}
public Builder setTrid(Trid trid) {
getInstance().trid = trid;
return this;
}
public Builder setBySuperuser(boolean bySuperuser) {
getInstance().bySuperuser = bySuperuser;
return this;
}
public Builder setReason(String reason) {
getInstance().reason = reason;
return this;
}
public Builder setRequestedByRegistrar(Boolean requestedByRegistrar) {
getInstance().requestedByRegistrar = requestedByRegistrar;
return this;
}
}
}