mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 20:47:52 +02:00
68768a561f
We're doing this to allow several new tests:
- xml files (that exist today)
- xml files with substitutions
- xml content (maybe? Currently private. Caching the files seems more readable)
- no data at all
Instead of having only one interface
eppToolVerifier.verifySent("file1.xml", "file2.xml");
we're refactoring to allow:
eppToolVerifier
.verifySent("file1.xml")
.verifySentAny() // we don't care about this epps
.verifySent("file2.xml", substitutions)
.verifyNoMoreSent();
In this case we're checking that "exactly 3 EPPs were sent, where the 1st one has content from file1.xml, and the 3rd one has the content from file2.xml, after the given substitutions were applied"
This also updates EppToolCommandTestCase to have only one EppToolVerifier, and
always finish by checking verifyNoMoreSent, meaning that in every test - all
sent epps must be accounted for (verified or skiped)
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177353887
321 lines
12 KiB
Java
321 lines
12 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.eppcommon.StatusValue.SERVER_UPDATE_PROHIBITED;
|
|
import static google.registry.testing.DatastoreHelper.newContactResource;
|
|
import static google.registry.testing.DatastoreHelper.newDomainResource;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveHost;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.JUnitBackports.expectThrows;
|
|
|
|
import com.beust.jcommander.ParameterException;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.googlecode.objectify.Key;
|
|
import google.registry.model.contact.ContactResource;
|
|
import google.registry.model.domain.DesignatedContact;
|
|
import google.registry.model.eppcommon.StatusValue;
|
|
import google.registry.model.host.HostResource;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link UpdateDomainCommand}. */
|
|
public class UpdateDomainCommandTest extends EppToolCommandTestCase<UpdateDomainCommand> {
|
|
|
|
@Test
|
|
public void testSuccess_complete() throws Exception {
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_nameservers=ns2.zdns.google,ns3.zdns.google",
|
|
"--add_admins=crr-admin2",
|
|
"--add_techs=crr-tech2",
|
|
"--add_statuses=serverDeleteProhibited",
|
|
"--remove_nameservers=ns4.zdns.google",
|
|
"--remove_admins=crr-admin1",
|
|
"--remove_techs=crr-tech1",
|
|
"--remove_statuses=serverHold",
|
|
"--registrant=crr-admin",
|
|
"--password=2fooBAR",
|
|
"example.tld");
|
|
eppVerifier.verifySent("domain_update_complete.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_multipleDomains() throws Exception {
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_nameservers=ns2.zdns.google,ns3.zdns.google",
|
|
"--add_admins=crr-admin2",
|
|
"--add_techs=crr-tech2",
|
|
"--add_statuses=serverDeleteProhibited",
|
|
"--remove_nameservers=ns4.zdns.google",
|
|
"--remove_admins=crr-admin1",
|
|
"--remove_techs=crr-tech1",
|
|
"--remove_statuses=serverHold",
|
|
"--registrant=crr-admin",
|
|
"--password=2fooBAR",
|
|
"example.tld",
|
|
"example.abc");
|
|
eppVerifier
|
|
.verifySent("domain_update_complete.xml")
|
|
.verifySent("domain_update_complete_abc.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_add() throws Exception {
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_nameservers=ns2.zdns.google,ns3.zdns.google",
|
|
"--add_admins=crr-admin2",
|
|
"--add_techs=crr-tech2",
|
|
"--add_statuses=serverDeleteProhibited",
|
|
"example.tld");
|
|
eppVerifier.verifySent("domain_update_add.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_remove() throws Exception {
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--remove_nameservers=ns4.zdns.google",
|
|
"--remove_admins=crr-admin1",
|
|
"--remove_techs=crr-tech1",
|
|
"--remove_statuses=serverHold",
|
|
"example.tld");
|
|
eppVerifier.verifySent("domain_update_remove.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_change() throws Exception {
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--registrant=crr-admin", "--password=2fooBAR", "example.tld");
|
|
eppVerifier.verifySent("domain_update_change.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_setNameservers() throws Exception {
|
|
HostResource host1 = persistActiveHost("ns1.zdns.google");
|
|
HostResource host2 = persistActiveHost("ns2.zdns.google");
|
|
ImmutableSet<Key<HostResource>> nameservers =
|
|
ImmutableSet.of(Key.create(host1), Key.create(host2));
|
|
persistResource(
|
|
newDomainResource("example.tld").asBuilder().setNameservers(nameservers).build());
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--nameservers=ns2.zdns.google,ns3.zdns.google", "example.tld");
|
|
eppVerifier.verifySent("domain_update_set_nameservers.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_setContacts() throws Exception {
|
|
ContactResource adminContact1 = persistResource(newContactResource("crr-admin1"));
|
|
ContactResource adminContact2 = persistResource(newContactResource("crr-admin2"));
|
|
ContactResource techContact1 = persistResource(newContactResource("crr-tech1"));
|
|
ContactResource techContact2 = persistResource(newContactResource("crr-tech2"));
|
|
Key<ContactResource> adminResourceKey1 = Key.create(adminContact1);
|
|
Key<ContactResource> adminResourceKey2 = Key.create(adminContact2);
|
|
Key<ContactResource> techResourceKey1 = Key.create(techContact1);
|
|
Key<ContactResource> techResourceKey2 = Key.create(techContact2);
|
|
|
|
persistResource(
|
|
newDomainResource("example.tld")
|
|
.asBuilder()
|
|
.setContacts(
|
|
ImmutableSet.of(
|
|
DesignatedContact.create(DesignatedContact.Type.ADMIN, adminResourceKey1),
|
|
DesignatedContact.create(DesignatedContact.Type.ADMIN, adminResourceKey2),
|
|
DesignatedContact.create(DesignatedContact.Type.TECH, techResourceKey1),
|
|
DesignatedContact.create(DesignatedContact.Type.TECH, techResourceKey2)))
|
|
.build());
|
|
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--admins=crr-admin2,crr-admin3",
|
|
"--techs=crr-tech2,crr-tech3",
|
|
"example.tld");
|
|
eppVerifier.verifySent("domain_update_set_contacts.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_setStatuses() throws Exception {
|
|
HostResource host = persistActiveHost("ns1.zdns.google");
|
|
ImmutableSet<Key<HostResource>> nameservers = ImmutableSet.of(Key.create(host));
|
|
persistResource(
|
|
newDomainResource("example.tld")
|
|
.asBuilder()
|
|
.setStatusValues(
|
|
ImmutableSet.of(
|
|
StatusValue.CLIENT_RENEW_PROHIBITED, StatusValue.SERVER_TRANSFER_PROHIBITED))
|
|
.setNameservers(nameservers)
|
|
.build());
|
|
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--statuses=clientRenewProhibited,serverHold", "example.tld");
|
|
eppVerifier.verifySent("domain_update_set_statuses.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_cantUpdateRegistryLockedDomainEvenAsSuperuser() throws Exception {
|
|
HostResource host = persistActiveHost("ns1.zdns.google");
|
|
ImmutableSet<Key<HostResource>> nameservers = ImmutableSet.of(Key.create(host));
|
|
persistResource(
|
|
newDomainResource("example.tld")
|
|
.asBuilder()
|
|
.setStatusValues(ImmutableSet.of(SERVER_UPDATE_PROHIBITED))
|
|
.setNameservers(nameservers)
|
|
.build());
|
|
|
|
Exception e =
|
|
expectThrows(
|
|
IllegalArgumentException.class,
|
|
() ->
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--statuses=clientRenewProhibited,serverHold",
|
|
"--superuser",
|
|
"example.tld"));
|
|
assertThat(e)
|
|
.hasMessageThat()
|
|
.containsMatch("The domain 'example.tld' has status SERVER_UPDATE_PROHIBITED");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_duplicateDomains() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class, "Duplicate arguments found");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--registrant=crr-admin",
|
|
"--password=2fooBAR",
|
|
"example.tld",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_missingDomain() throws Exception {
|
|
thrown.expect(ParameterException.class, "Main parameters are required");
|
|
runCommandForced("--client=NewRegistrar", "--registrant=crr-admin", "--password=2fooBAR");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_missingClientId() throws Exception {
|
|
thrown.expect(ParameterException.class, "--client");
|
|
runCommandForced("--registrant=crr-admin", "--password=2fooBAR", "example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_addTooManyNameServers() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class, "You can add at most 13 nameservers");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_nameservers=ns1.zdns.google,ns2.zdns.google,ns3.zdns.google,ns4.zdns.google,"
|
|
+ "ns5.zdns.google,ns6.zdns.google,ns7.zdns.google,ns8.zdns.google,"
|
|
+ "ns9.zdns.google,ns10.zdns.google,ns11.zdns.google,ns12.zdns.google,"
|
|
+ "ns13.zdns.google,ns14.zdns.google",
|
|
"--add_admins=crr-admin2",
|
|
"--add_techs=crr-tech2",
|
|
"--add_statuses=serverDeleteProhibited",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedNameserversAndAddNameservers() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the nameservers flag, "
|
|
+ "you cannot use the add_nameservers and remove_nameservers flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_nameservers=ns1.zdns.google",
|
|
"--nameservers=ns2.zdns.google,ns3.zdns.google",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedNameserversAndRemoveNameservers() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the nameservers flag, "
|
|
+ "you cannot use the add_nameservers and remove_nameservers flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--remove_nameservers=ns1.zdns.google",
|
|
"--nameservers=ns2.zdns.google,ns3.zdns.google",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedAdminsAndAddAdmins() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the admins flag, you cannot use the add_admins and remove_admins flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--add_admins=crr-admin2", "--admins=crr-admin2", "example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedAdminsAndRemoveAdmins() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the admins flag, you cannot use the add_admins and remove_admins flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--remove_admins=crr-admin2",
|
|
"--admins=crr-admin2",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedTechsAndAddTechs() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the techs flag, you cannot use the add_techs and remove_techs flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--add_techs=crr-tech2", "--techs=crr-tech2", "example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedTechsAndRemoveTechs() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the techs flag, you cannot use the add_techs and remove_techs flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar", "--remove_techs=crr-tech2", "--techs=crr-tech2", "example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedStatusesAndAddStatuses() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the statuses flag, "
|
|
+ "you cannot use the add_statuses and remove_statuses flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--add_statuses=serverHold",
|
|
"--statuses=crr-serverHold",
|
|
"example.tld");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_providedStatusesAndRemoveStatuses() throws Exception {
|
|
thrown.expect(
|
|
IllegalArgumentException.class,
|
|
"If you provide the statuses flag, "
|
|
+ "you cannot use the add_statuses and remove_statuses flags.");
|
|
runCommandForced(
|
|
"--client=NewRegistrar",
|
|
"--remove_statuses=serverHold",
|
|
"--statuses=crr-serverHold",
|
|
"example.tld");
|
|
}
|
|
}
|