google-nomulus/javatests/google/registry/tools/EppToolCommandTest.java
guyben 68768a561f Refactor EppToolVerifier to accept chaining verify commands
We're doing this to allow several new tests:
- xml files (that exist today)
- xml files with substitutions
- xml content (maybe? Currently private. Caching the files seems more readable)
- no data at all

Instead of having only one interface

eppToolVerifier.verifySent("file1.xml", "file2.xml");

we're refactoring to allow:
eppToolVerifier
  .verifySent("file1.xml")
  .verifySentAny() // we don't care about this epps
  .verifySent("file2.xml", substitutions)
  .verifyNoMoreSent();

In this case we're checking that "exactly 3 EPPs were sent, where the 1st one has content from file1.xml, and the 3rd one has the content from file2.xml, after the given substitutions were applied"

This also updates EppToolCommandTestCase to have only one EppToolVerifier, and
always finish by checking verifyNoMoreSent, meaning that in every test - all
sent epps must be accounted for (verified or skiped)

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=177353887
2017-12-01 22:14:06 -05:00

77 lines
2.4 KiB
Java

// Copyright 2017 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.tools;
import com.beust.jcommander.Parameter;
import com.beust.jcommander.Parameters;
import google.registry.tools.server.ToolsTestData;
import java.util.List;
import org.junit.Test;
/** Unit tests for {@link EppToolCommand}. */
public class EppToolCommandTest extends EppToolCommandTestCase<EppToolCommand> {
/** Dummy implementation of EppToolCommand. */
@Parameters(separators = " =", commandDescription = "Dummy EppToolCommand")
static class TestEppToolCommand extends EppToolCommand {
@Parameter(names = {"--client"})
String clientId;
@Parameter
List<String> xmlPayloads;
@Override
void initEppToolCommand() throws Exception {
for (String xmlData : xmlPayloads) {
addXmlCommand(clientId, xmlData);
}
}
}
@Override
protected EppToolCommand newCommandInstance() {
return new TestEppToolCommand();
}
@Test
public void testSuccess_singleXmlCommand() throws Exception {
// The choice of xml file is arbitrary.
runCommandForced(
"--client=NewRegistrar",
ToolsTestData.loadUtf8("contact_create.xml"));
eppVerifier.verifySent("contact_create.xml");
}
@Test
public void testSuccess_multipleXmlCommands() throws Exception {
// The choice of xml files is arbitrary.
runCommandForced(
"--client=NewRegistrar",
ToolsTestData.loadUtf8("contact_create.xml"),
ToolsTestData.loadUtf8("domain_check.xml"),
ToolsTestData.loadUtf8("domain_check_fee.xml"));
eppVerifier
.verifySent("contact_create.xml")
.verifySent("domain_check.xml")
.verifySent("domain_check_fee.xml");
}
@Test
public void testFailure_nonexistentClientId() throws Exception {
thrown.expect(IllegalArgumentException.class, "fakeclient");
runCommandForced("--client=fakeclient", "fake-xml");
}
}