google-nomulus/java/google/registry
guyben 633eb3179a Skip RRS update if existing records are equal to desired records
This is done first and formost to stop "empty" commits that cause errors in
publishDnsUpdates. The reason being that the Cloud DNS api fails when there are
no updates at all in a change.

Allowing this is a requirement for the writer to be idempotent - if we delete a
domain, then run the writer to delete it again - we'll get 0 additions and 0
deletions which fails.

This isn't theoretical either - we've seen it happen, causing a
publishDnsUpdates to fail over and over again.

While fixing this, we also remove all RRS that are common between additions and
deletions. This is just an optimization and shouldn't affect behavior.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=179525218
2017-12-27 11:18:21 -05:00
..
backup Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
batch Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
beam Add beam package to open source build 2017-12-13 12:43:45 -05:00
bigquery Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
billing Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
braintree Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
builddefs Rename set to depset in .bzl and BUILD files 2017-08-29 16:53:21 -04:00
config Put help information on the main page 2017-12-13 12:43:45 -05:00
cron Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
dns Skip RRS update if existing records are equal to desired records 2017-12-27 11:18:21 -05:00
eclipse Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
env Rationalize prod/sandbox instance numbers to 50/5/50 2017-12-27 11:13:42 -05:00
export Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
flows Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
gcs Use compound return statements for greater readability 2017-11-07 17:12:57 -05:00
groups Clean up some code quality issues 2017-12-01 22:14:06 -05:00
idn Run buildifier on codebase to format BUILD files 2016-11-28 18:15:21 -05:00
keyring Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
loadtest Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
mapreduce Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
model Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
module Inject VoidDnsWriter to backend 2017-12-27 11:10:33 -05:00
monitoring Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
pricing Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
proxy Add ability to configure proxy quotas 2017-12-13 12:43:45 -05:00
rdap Add next page navigation for RDAP domain searches 2017-12-27 11:15:18 -05:00
rde Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
reporting Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
request Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
security Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
storage/drive Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tldconfig/idn Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
tmch Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
tools Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
ui Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
util Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
whois Replace com.google.common.base.Function with java.util.function.Function 2017-12-27 11:08:55 -05:00
xjc Clean up some code quality issues 2017-12-01 22:14:06 -05:00
xml Remove unnecessary generic type arguments 2017-11-21 18:17:31 -05:00
BUILD Add nocron ear and deployer rules for the crash environment 2017-10-04 16:16:45 -04:00
repositories.bzl Add beam package to open source build 2017-12-13 12:43:45 -05:00