google-nomulus/javatests/com/google/domain/registry
nickfelt 7e80b5646f Make Cancellation OneTime vs Recurring logic explicit
This CL does a very similar cleanup to Cancellation as the diffbase
does to GracePeriod - see []  It simplifes logic where we
used to overload methods to accept eitherw OneTime or Recurring billing
events refs, despite storing them in separate fields in the entity
(since BillingEvent is not a polymorphic superclass, just a Java-only
one, you can't store them as refs to BillingEvent).

That overloading was ultimately only there as a convenience/hack from
when we added Recurring events and didn't want to go back and change
everything.  It obfuscates what's really going on, requires extra
casting/loss of type-safety, and relies on indirect signals (e.g. the
Billing event reason being AUTO_RENEW) to guess what the right billing
event type is.  That latter aspect will likely no longer work in a
monthly billing world, and was brittle anyways (as came up in the
context of removing the AUTO_RENEW reason - see []
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=117165174
2016-03-16 21:20:25 -04:00
..
backup Import code from internal repository to git 2016-03-01 17:59:16 -05:00
bigquery Import code from internal repository to git 2016-03-01 17:59:16 -05:00
config Import code from internal repository to git 2016-03-01 17:59:16 -05:00
cron Import code from internal repository to git 2016-03-01 17:59:16 -05:00
dns Import code from internal repository to git 2016-03-01 17:59:16 -05:00
export Add [] to export domain lists to GCS 2016-03-10 16:48:39 -05:00
flows Make Cancellation OneTime vs Recurring logic explicit 2016-03-16 21:20:25 -04:00
groups Import code from internal repository to git 2016-03-01 17:59:16 -05:00
mapreduce Import code from internal repository to git 2016-03-01 17:59:16 -05:00
model Make Cancellation OneTime vs Recurring logic explicit 2016-03-16 21:20:25 -04:00
module Import code from internal repository to git 2016-03-01 17:59:16 -05:00
monitoring/whitebox Import code from internal repository to git 2016-03-01 17:59:16 -05:00
rdap RDAP: Add boilerplate entries required by ICANN RDAP Profile 2016-03-04 16:25:25 -05:00
rde Import code from internal repository to git 2016-03-01 17:59:16 -05:00
request Import code from internal repository to git 2016-03-01 17:59:16 -05:00
security Import code from internal repository to git 2016-03-01 17:59:16 -05:00
server Delete admin console 2016-03-10 16:48:39 -05:00
storage/drive Import code from internal repository to git 2016-03-01 17:59:16 -05:00
testing Add [] to export domain lists to GCS 2016-03-10 16:48:39 -05:00
tldconfig/idn Import code from internal repository to git 2016-03-01 17:59:16 -05:00
tmch Import code from internal repository to git 2016-03-01 17:59:16 -05:00
tools Import code from internal repository to git 2016-03-01 17:59:16 -05:00
ui Delete admin console 2016-03-10 16:48:39 -05:00
util Import code from internal repository to git 2016-03-01 17:59:16 -05:00
whois Import code from internal repository to git 2016-03-01 17:59:16 -05:00
xjc Import code from internal repository to git 2016-03-01 17:59:16 -05:00
xml Import code from internal repository to git 2016-03-01 17:59:16 -05:00