mirror of
https://github.com/google/nomulus.git
synced 2025-08-02 16:02:10 +02:00
After this CL, "support" accounts (accounts that are part of the "support" G-Suite group) will the same access to the registrar console as GCP "admins". However, they don't won't have access to the GCP project itself. We could give them their own Role in the future (say SUPPORT) and give them different access than "admins", but right now we don't need it and YAGNI or something :) NOTE: we identify users by their email (they need to be logged in to a google account). I don't know if that's best practice, since I guess different google accounts might have the same email address. However, G-Suite groups' membership is by email so there's not much we can do about it if we want to use G-Suite groups. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220804273
254 lines
9.2 KiB
Java
254 lines
9.2 KiB
Java
// Copyright 2018 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.ui.server.registrar;
|
|
|
|
import static google.registry.model.ofy.ObjectifyService.ofy;
|
|
|
|
import com.google.appengine.api.users.User;
|
|
import com.google.common.annotations.VisibleForTesting;
|
|
import com.google.common.base.Strings;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.google.common.collect.ImmutableSetMultimap;
|
|
import com.google.common.flogger.FluentLogger;
|
|
import dagger.Lazy;
|
|
import google.registry.config.RegistryConfig.Config;
|
|
import google.registry.groups.GroupsConnection;
|
|
import google.registry.model.registrar.Registrar;
|
|
import google.registry.model.registrar.RegistrarContact;
|
|
import google.registry.request.HttpException.ForbiddenException;
|
|
import google.registry.request.auth.AuthResult;
|
|
import google.registry.request.auth.UserAuthInfo;
|
|
import javax.annotation.concurrent.Immutable;
|
|
import javax.inject.Inject;
|
|
|
|
/**
|
|
* Allows access only to {@link Registrar}s the current user has access to.
|
|
*
|
|
* <p>A user has OWNER role on a Registrar if there exists a {@link RegistrarContact} with
|
|
* that user's gaeId and the registrar as a parent.
|
|
*
|
|
* <p>An admin has in addition OWNER role on {@link #registryAdminClientId}.
|
|
*
|
|
* <p>An admin also has ADMIN role on ALL registrars.
|
|
*/
|
|
@Immutable
|
|
public class AuthenticatedRegistrarAccessor {
|
|
|
|
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
|
|
|
|
/** The role under which access is granted. */
|
|
public enum Role {
|
|
OWNER,
|
|
ADMIN
|
|
}
|
|
|
|
AuthResult authResult;
|
|
String registryAdminClientId;
|
|
|
|
/**
|
|
* Gives all roles a user has for a given clientId.
|
|
*
|
|
* <p>The order is significant, with "more specific to this user" coming first.
|
|
*/
|
|
private final ImmutableSetMultimap<String, Role> roleMap;
|
|
|
|
/**
|
|
* Overriding the injected {@link GroupsConnection} for tests.
|
|
*
|
|
* <p>{@link GroupsConnection} needs the injected DelegatedCredential GoogleCredential. However,
|
|
* this can't be initialized in the test environment.
|
|
*
|
|
* <p>The test server used in the javatests/google/registry/webdriver/ tests will hang if we try
|
|
* to instantiate the {@link GroupsConnection}. So instead we inject a {@link Lazy} version and
|
|
* allow tests to override the injected instace with (presumabley) a mock insteance.
|
|
*/
|
|
@VisibleForTesting public static GroupsConnection overrideGroupsConnection = null;
|
|
|
|
@Inject
|
|
public AuthenticatedRegistrarAccessor(
|
|
AuthResult authResult,
|
|
@Config("registryAdminClientId") String registryAdminClientId,
|
|
@Config("gSuiteSupportGroupEmailAddress") String gSuiteSupportGroupEmailAddress,
|
|
Lazy<GroupsConnection> groupsConnection) {
|
|
this(
|
|
authResult,
|
|
registryAdminClientId,
|
|
gSuiteSupportGroupEmailAddress,
|
|
overrideGroupsConnection != null ? overrideGroupsConnection : groupsConnection.get());
|
|
}
|
|
|
|
AuthenticatedRegistrarAccessor(
|
|
AuthResult authResult,
|
|
@Config("registryAdminClientId") String registryAdminClientId,
|
|
@Config("gSuiteSupportGroupEmailAddress") String gSuiteSupportGroupEmailAddress,
|
|
GroupsConnection groupsConnection) {
|
|
this.authResult = authResult;
|
|
this.registryAdminClientId = registryAdminClientId;
|
|
this.roleMap =
|
|
createRoleMap(
|
|
authResult,
|
|
registryAdminClientId,
|
|
groupsConnection,
|
|
gSuiteSupportGroupEmailAddress);
|
|
|
|
logger.atInfo().log(
|
|
"%s has the following roles: %s", authResult.userIdForLogging(), roleMap);
|
|
}
|
|
|
|
/**
|
|
* A map that gives all roles a user has for a given clientId.
|
|
*
|
|
* <p>Throws a {@link ForbiddenException} if the user is not logged in.
|
|
*
|
|
* <p>The result is ordered starting from "most specific to this user".
|
|
*
|
|
* <p>If you want to load the {@link Registrar} object from these (or any other) {@code clientId},
|
|
* in order to perform actions on behalf of a user, you must use {@link #getRegistrar} which makes
|
|
* sure the user has permissions.
|
|
*
|
|
* <p>Note that this is an OPTIONAL step in the authentication - only used if we don't have any
|
|
* other clue as to the requested {@code clientId}. It is perfectly OK to get a {@code clientId}
|
|
* from any other source, as long as the registrar is then loaded using {@link #getRegistrar}.
|
|
*/
|
|
public ImmutableSetMultimap<String, Role> getAllClientIdWithRoles() {
|
|
return roleMap;
|
|
}
|
|
|
|
/**
|
|
* "Guesses" which client ID the user wants from all those they have access to.
|
|
*
|
|
* <p>If no such ClientIds exist, throws a ForbiddenException.
|
|
*
|
|
* <p>This should be the ClientId "most likely wanted by the user".
|
|
*
|
|
* <p>If you want to load the {@link Registrar} object from this (or any other) {@code clientId},
|
|
* in order to perform actions on behalf of a user, you must use {@link #getRegistrar} which makes
|
|
* sure the user has permissions.
|
|
*
|
|
* <p>Note that this is an OPTIONAL step in the authentication - only used if we don't have any
|
|
* other clue as to the requested {@code clientId}. It is perfectly OK to get a {@code clientId}
|
|
* from any other source, as long as the registrar is then loaded using {@link #getRegistrar}.
|
|
*/
|
|
public String guessClientId() {
|
|
verifyLoggedIn();
|
|
return getAllClientIdWithRoles().keySet().stream()
|
|
.findFirst()
|
|
.orElseThrow(
|
|
() ->
|
|
new ForbiddenException(
|
|
String.format(
|
|
"%s isn't associated with any registrar",
|
|
authResult.userIdForLogging())));
|
|
}
|
|
|
|
/**
|
|
* Loads a Registrar IFF the user is authorized.
|
|
*
|
|
* <p>Throws a {@link ForbiddenException} if the user is not logged in, or not authorized to
|
|
* access the requested registrar.
|
|
*
|
|
* @param clientId ID of the registrar we request
|
|
*/
|
|
public Registrar getRegistrar(String clientId) {
|
|
verifyLoggedIn();
|
|
|
|
ImmutableSet<Role> roles = getAllClientIdWithRoles().get(clientId);
|
|
|
|
if (roles.isEmpty()) {
|
|
throw new ForbiddenException(
|
|
String.format(
|
|
"%s doesn't have access to registrar %s",
|
|
authResult.userIdForLogging(), clientId));
|
|
}
|
|
|
|
Registrar registrar =
|
|
Registrar.loadByClientId(clientId)
|
|
.orElseThrow(
|
|
() -> new ForbiddenException(String.format("Registrar %s not found", clientId)));
|
|
|
|
if (!clientId.equals(registrar.getClientId())) {
|
|
logger.atSevere().log(
|
|
"registrarLoader.apply(clientId) returned a Registrar with a different clientId. "
|
|
+ "Requested: %s, returned: %s.",
|
|
clientId, registrar.getClientId());
|
|
throw new ForbiddenException("Internal error - please check logs");
|
|
}
|
|
|
|
logger.atInfo().log(
|
|
"%s has %s access to registrar %s.", authResult.userIdForLogging(), roles, clientId);
|
|
return registrar;
|
|
}
|
|
|
|
private static boolean checkIsSupport(
|
|
GroupsConnection groupsConnection, String userEmail, String supportEmail) {
|
|
if (Strings.isNullOrEmpty(supportEmail)) {
|
|
return false;
|
|
}
|
|
try {
|
|
return groupsConnection.isMemberOfGroup(userEmail, supportEmail);
|
|
} catch (RuntimeException e) {
|
|
logger.atSevere().withCause(e).log(
|
|
"Error checking whether email %s belongs to support group %s."
|
|
+ " Skipping support role check",
|
|
userEmail, supportEmail);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
private static ImmutableSetMultimap<String, Role> createRoleMap(
|
|
AuthResult authResult,
|
|
String registryAdminClientId,
|
|
GroupsConnection groupsConnection,
|
|
String gSuiteSupportGroupEmailAddress) {
|
|
|
|
if (!authResult.userAuthInfo().isPresent()) {
|
|
return ImmutableSetMultimap.of();
|
|
}
|
|
|
|
UserAuthInfo userAuthInfo = authResult.userAuthInfo().get();
|
|
|
|
User user = userAuthInfo.user();
|
|
boolean isAdmin = userAuthInfo.isUserAdmin();
|
|
boolean isSupport =
|
|
checkIsSupport(groupsConnection, user.getEmail(), gSuiteSupportGroupEmailAddress);
|
|
|
|
ImmutableSetMultimap.Builder<String, Role> builder = new ImmutableSetMultimap.Builder<>();
|
|
|
|
ofy()
|
|
.load()
|
|
.type(RegistrarContact.class)
|
|
.filter("gaeUserId", user.getUserId())
|
|
.forEach(contact -> builder.put(contact.getParent().getName(), Role.OWNER));
|
|
if (isAdmin && !Strings.isNullOrEmpty(registryAdminClientId)) {
|
|
builder.put(registryAdminClientId, Role.OWNER);
|
|
}
|
|
|
|
if (isAdmin || isSupport) {
|
|
// Admins and support have access to all registrars
|
|
ofy()
|
|
.load()
|
|
.type(Registrar.class)
|
|
.forEach(registrar -> builder.put(registrar.getClientId(), Role.ADMIN));
|
|
}
|
|
|
|
return builder.build();
|
|
}
|
|
|
|
private void verifyLoggedIn() {
|
|
if (!authResult.userAuthInfo().isPresent()) {
|
|
throw new ForbiddenException("Not logged in");
|
|
}
|
|
}
|
|
}
|