google-nomulus/javatests/google/registry
guyben 552940a816 Remove the reduntant 'afterFinalFailure' from Retrier
'afterFinalFailure' is called just before rethrowing a non-retrying error from
the retrier. This can happen either because the exception shouldn't be retried,
or because we exceeded the maximum number of retries.

The same thing can be done by catching that thrown error outside of the
retrier:

retrier.callWithRetry(
  callable,
  new FailureReporter() {
    @Override
    void afterFinalFailure(Throwable thrown, int failures) {
      // do something with thrown
    }
  },
  RetriableException.class);

is (almost) the same as:

try {
  retrier.callWithRetry(callable, RetriableException.class);
} catch (Throwable thrown) {
  // do something with thrown
  throw thrown;
}

("almost" because the retrier might wrap the Throwable in a RuntimeException,
so you might need to getCause or getRootCause. Also - there is the
"beforeRetry" I ignored for the example)

Removing "afterFinalFailure" also makes the FailureReporter in line with Java 8
functional interface - meaning we can more easily create it when we do need to
override "beforeRetry".

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=189972101
2018-04-02 16:26:19 -04:00
..
backup Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
batch Accept a list of TLDs on which to delete "prober" (test) data. 2018-03-06 19:03:48 -05:00
beam Move invoice generation to billing bucket and improve emailing 2018-01-19 14:34:14 -05:00
bigquery Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
builddefs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
config Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
cron Remove empty TLD parameter when fanning out without TLDs 2018-04-02 16:24:27 -04:00
dns Add sharded DNS publishing capability 2018-03-06 19:14:26 -05:00
export Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
flows Default missing type= argument to "registration" in launch:create EPP extension 2018-04-02 16:22:54 -04:00
groups Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
keyring Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
mapreduce/inputs Remove the JVM flags -XX:PermSize and -XX:MaxPermSize 2018-03-19 18:25:04 -04:00
model Make return value of ClaimsListShard.getClaimKey() Optional 2018-03-06 19:15:52 -05:00
module Refactor ICANN reporting and billing into common package 2018-02-01 21:56:06 -05:00
monitoring/whitebox Add dependencies on classes that are not in the default modules in JDK 9 2018-02-01 22:00:49 -05:00
pricing Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
proxy Clean up some code quality issues in GCP proxy 2018-03-19 18:44:12 -04:00
rdap RDAP: Show registrar entity even if contacts are redacted 2018-03-06 19:00:47 -05:00
rde Remove references to Eclipse 2018-03-19 18:45:41 -04:00
reporting Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
request Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
security Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
server Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
storage/drive Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
testing Remove references to Eclipse 2018-03-19 18:45:41 -04:00
tldconfig/idn Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
tmch Remove references to Eclipse 2018-03-19 18:45:41 -04:00
tools Add a "shell" pseudo-command to nomulus tool 2018-03-19 18:22:01 -04:00
ui Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
util Remove the reduntant 'afterFinalFailure' from Retrier 2018-04-02 16:26:19 -04:00
whois Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
xjc Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
xml Add basic AllocationToken validation/redemption for domain creates 2018-01-19 14:28:26 -05:00