nickfelt 51f5c8bcfe Improve tests for RegistryTool and GtechTool ... This improves the tests by: 1) Adding tests for alphabetical ordering of the command maps, to keep them organized, and fixing existing mis-orderings. Note that this is a no-op test for RegistryTool since it uses ImmutableSortedMap (to resort the commands after inserting GtechTool.COMMAND_MAP), but it'll be relevant in the upcoming CL when they get merged. I changed GtechTool.COMMAND_MAP to use regular ImmutableMap. 2) Checking that RegistryTool.COMMAND_MAP (the full map, after the existing GtechTool.COMMAND_MAP has been merged in) contains the exact same set of commands as all the concrete classes implementing Command that we can find. This is a stronger test than what we had before, which just checked that every Command class appeared in RegistryTool (i.e. that RegistryTool's commands are a superset of all Commands found). You'd think that it'd be impossible for RegistryTool to contain commands that aren't in the set of Commands we found, but it is if we're not searching for commands properly, which we weren't (we were only checking within the .tools package and not within any subpackages (e.g. tools.javascrap). This has now been fixed. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134451859		2016-10-03 15:51:08 -04:00
..
com/google	Fix up license headers and Python linting	2016-08-02 19:16:42 -04:00
google/registry	Improve tests for RegistryTool and GtechTool	2016-10-03 15:51:08 -04:00