mirror of
https://github.com/google/nomulus.git
synced 2025-05-16 17:37:13 +02:00
Here's an alternate approach that I think simplifies the existing code quite a bit. Now instead of doing: RegistryToolEnvironment.loadFromArgs(args); RegistryToolEnvironment.get().setup(); You just do one chained call: RegistryToolEnvironment.parseFromArgs(args).setup(); or call setup() on a known environment constant: RegistryToolEnvironment.ALPHA.setup(); This avoids having loadFromArgs() implicitly set the active env (but *not* do setup) and then having setup() *not* set the active env, both of which were confusing. Now parseFromArgs() is only responsible for parsing from args, and setup() both sets the env as the active one and does the environment variable setup (which also ensures that the RegistryToolEnvironment.instance field doesn't get out of sync with the RegistryEnvironment value). In addition, this CL adds a runCommandInEnvironment() method to CommandTestCase and ensures that the UNITTEST environment is always set before constructing the default command instance. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=117492978
112 lines
3.9 KiB
Java
112 lines
3.9 KiB
Java
// Copyright 2016 Google Inc. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.domain.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.rules.ExpectedException;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link RegistryToolEnvironment}. */
|
|
@RunWith(JUnit4.class)
|
|
public class RegistryToolEnvironmentTest {
|
|
|
|
@Rule
|
|
public final ExpectedException thrown = ExpectedException.none();
|
|
|
|
@Test
|
|
public void testGet_withoutSetup_throws() throws Exception {
|
|
thrown.expect(IllegalStateException.class);
|
|
RegistryToolEnvironment.get();
|
|
}
|
|
|
|
@Test
|
|
public void testSetup_changesEnvironmentReturnedByGet() throws Exception {
|
|
RegistryToolEnvironment.UNITTEST.setup();
|
|
assertThat(RegistryToolEnvironment.get()).isEqualTo(RegistryToolEnvironment.UNITTEST);
|
|
|
|
RegistryToolEnvironment.ALPHA.setup();
|
|
assertThat(RegistryToolEnvironment.get()).isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_shortNotation_works() throws Exception {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e", "alpha" }))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_longNotation_works() throws Exception {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "--environment", "alpha" }))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_uppercase_works() throws Exception {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e", "QA" }))
|
|
.isEqualTo(RegistryToolEnvironment.QA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_equalsNotation_works() throws Exception {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e=sandbox" }))
|
|
.isEqualTo(RegistryToolEnvironment.SANDBOX);
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "--environment=sandbox" }))
|
|
.isEqualTo(RegistryToolEnvironment.SANDBOX);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_envFlagAfterCommandName_getsIgnored() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class);
|
|
RegistryToolEnvironment.parseFromArgs(new String[] {
|
|
"registrar_activity_report",
|
|
"-e", "1406851199"});
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_missingEnvironmentFlag_throwsIae() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class);
|
|
RegistryToolEnvironment.parseFromArgs(new String[] {});
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_extraEnvFlagAfterCommandName_getsIgnored() throws Exception {
|
|
String[] args = new String[] {
|
|
"-e", "alpha",
|
|
"registrar_activity_report",
|
|
"-e", "1406851199"};
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(args))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_loggingFlagWithUnderscores_isntConsideredCommand() throws Exception {
|
|
String[] args = new String[] {
|
|
"--logging_properties_file", "my_file.properties",
|
|
"-e", "alpha",
|
|
"list_tlds"};
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(args))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_badName_throwsIae() throws Exception {
|
|
thrown.expect(IllegalArgumentException.class);
|
|
RegistryToolEnvironment.parseFromArgs(new String[] { "-e", "alphaville" });
|
|
}
|
|
}
|