mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 04:27:51 +02:00
This change replaces all Ref objects in the code with Key objects. These are stored in datastore as the same object (raw datastore keys), so this is not a model change. Our best practices doc says to use Keys not Refs because: * The .get() method obscures what's actually going on - Much harder to visually audit the code for datastore loads - Hard to distinguish Ref<T> get()'s from Optional get()'s and Supplier get()'s * Implicit ofy().load() offers much less control - Antipattern for ultimate goal of making Ofy injectable - Can't control cache use or batch loading without making ofy() explicit anyway * Serialization behavior is surprising and could be quite dangerous/incorrect - Can lead to serialization errors. If it actually worked "as intended", it would lead to a Ref<> on a serialized object being replaced upon deserialization with a stale copy of the old value, which could potentially break all kinds of transactional expectations * Having both Ref<T> and Key<T> introduces extra boilerplate everywhere - E.g. helper methods all need to have Ref and Key overloads, or you need to call .key() to get the Key<T> for every Ref<T> you want to pass in - Creating a Ref<T> is more cumbersome, since it doesn't have all the create() overloads that Key<T> has, only create(Key<T>) and create(Entity) - no way to create directly from kind+ID/name, raw Key, websafe key string, etc. (Note that Refs are treated specially by Objectify's @Load method and Keys are not; we don't use that feature, but it is the one advantage Refs have over Keys.) The direct impetus for this change is that I am trying to audit our use of memcache, and the implicit .get() calls to datastore were making that very hard. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=131965491
139 lines
5.6 KiB
Java
139 lines
5.6 KiB
Java
// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.flows;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.EppResourceUtils.loadByUniqueId;
|
|
import static google.registry.model.ofy.ObjectifyService.ofy;
|
|
import static google.registry.model.tmch.ClaimsListShardTest.createTestClaimsListShard;
|
|
|
|
import com.google.common.base.Predicate;
|
|
import com.google.common.collect.FluentIterable;
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.common.collect.ImmutableMap;
|
|
import com.googlecode.objectify.Key;
|
|
import google.registry.flows.EppException.CommandUseErrorException;
|
|
import google.registry.model.EppResource;
|
|
import google.registry.model.domain.launch.ApplicationIdTargetExtension;
|
|
import google.registry.model.eppinput.EppInput.ResourceCommandWrapper;
|
|
import google.registry.model.eppinput.ResourceCommand;
|
|
import google.registry.model.index.EppResourceIndex;
|
|
import google.registry.model.index.EppResourceIndexBucket;
|
|
import google.registry.model.tmch.ClaimsListShard.ClaimsListRevision;
|
|
import google.registry.model.tmch.ClaimsListShard.ClaimsListSingleton;
|
|
import google.registry.testing.ExceptionRule;
|
|
import google.registry.util.TypeUtils.TypeInstantiator;
|
|
import org.joda.time.DateTime;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
|
|
/**
|
|
* Base class for resource flow unit tests.
|
|
*
|
|
* @param <F> the flow type
|
|
* @param <R> the resource type
|
|
*/
|
|
public abstract class ResourceFlowTestCase<F extends Flow, R extends EppResource>
|
|
extends FlowTestCase<F> {
|
|
|
|
@Rule
|
|
public final ExceptionRule thrown = new ExceptionRule();
|
|
|
|
private R reloadResourceByUniqueId(DateTime now) throws Exception {
|
|
// Force the session to be cleared so that when we read it back, we read from the datastore and
|
|
// not from the transaction cache or memcache.
|
|
ofy().clearSessionCache();
|
|
return loadByUniqueId(getResourceClass(), getUniqueIdFromCommand(), now);
|
|
}
|
|
|
|
protected R reloadResourceByUniqueId() throws Exception {
|
|
return reloadResourceByUniqueId(clock.nowUtc());
|
|
}
|
|
|
|
protected R reloadResourceByUniqueIdYesterday() throws Exception {
|
|
return reloadResourceByUniqueId(clock.nowUtc().minusDays(1));
|
|
}
|
|
|
|
protected <T extends EppResource> T reloadResourceAndCloneAtTime(T resource, DateTime now) {
|
|
// Force the session to be cleared.
|
|
ofy().clearSessionCache();
|
|
@SuppressWarnings("unchecked")
|
|
T refreshedResource = (T) ofy().load().entity(resource).now().cloneProjectedAtTime(now);
|
|
return refreshedResource;
|
|
}
|
|
|
|
protected ResourceCommand.SingleResourceCommand getResourceCommand() throws Exception {
|
|
return (ResourceCommand.SingleResourceCommand)
|
|
((ResourceCommandWrapper) eppLoader.getEpp().getCommandWrapper().getCommand())
|
|
.getResourceCommand();
|
|
}
|
|
|
|
/**
|
|
* We have to duplicate the logic from SingleResourceFlow.getTargetId() here. However, given the
|
|
* choice between making that method public, and duplicating its logic, it seems better to muddy
|
|
* the test code rather than the production code.
|
|
*/
|
|
protected String getUniqueIdFromCommand() throws Exception {
|
|
ApplicationIdTargetExtension extension =
|
|
eppLoader.getEpp().getSingleExtension(ApplicationIdTargetExtension.class);
|
|
return extension == null ? getResourceCommand().getTargetId() : extension.getApplicationId();
|
|
}
|
|
|
|
protected Class<R> getResourceClass() {
|
|
return new TypeInstantiator<R>(getClass()){}.getExactType();
|
|
}
|
|
|
|
/**
|
|
* Persists a testing claims list to Datastore that contains a single shard.
|
|
*/
|
|
protected void persistClaimsList(ImmutableMap<String, String> labelsToKeys) {
|
|
ClaimsListSingleton singleton = new ClaimsListSingleton();
|
|
Key<ClaimsListRevision> revision = ClaimsListRevision.createKey(singleton);
|
|
singleton.setActiveRevision(revision);
|
|
ofy().saveWithoutBackup().entity(singleton).now();
|
|
if (!labelsToKeys.isEmpty()) {
|
|
ofy().saveWithoutBackup()
|
|
.entity(createTestClaimsListShard(clock.nowUtc(), labelsToKeys, revision))
|
|
.now();
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void testRequiresLogin() throws Exception {
|
|
thrown.expect(CommandUseErrorException.class);
|
|
sessionMetadata.setClientId(null);
|
|
runFlow();
|
|
}
|
|
|
|
/**
|
|
* Confirms that an EppResourceIndex entity exists in datastore for a given resource.
|
|
*/
|
|
protected static <T extends EppResource> void assertEppResourceIndexEntityFor(final T resource) {
|
|
ImmutableList<EppResourceIndex> indices = FluentIterable
|
|
.from(ofy().load()
|
|
.type(EppResourceIndex.class)
|
|
.filter("kind", Key.getKind(resource.getClass())))
|
|
.filter(new Predicate<EppResourceIndex>() {
|
|
@Override
|
|
public boolean apply(EppResourceIndex index) {
|
|
return Key.create(resource).equals(index.getKey())
|
|
&& ofy().load().key(index.getKey()).now().equals(resource);
|
|
}})
|
|
.toList();
|
|
assertThat(indices).hasSize(1);
|
|
assertThat(indices.get(0).getBucket())
|
|
.isEqualTo(EppResourceIndexBucket.getBucketKey(Key.create(resource)));
|
|
}
|
|
}
|