zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-02 04:57:51 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/export
History
ctingue 1f5a8d5542 Fix off-by-one issue in SheetSynchronizer 
This doesn't change the end result of a successful run, though this is what a typical flow looks like prior to this fix:

Consider a sheet with 10 data rows (+ 1 header row = 11). A 10-row data set will call worksheet.setRowCount(10), which truncates the last row of the existing sheet. This row will eventually be added again in the last for loop, but if the synchronizer fails mid-sync, this last row will remain dropped. This fix will prevent this last row from being dropped.

This doesn't fix the broader issue of SheetSynchronizer not behaving transactionally -- that's a different can of worms.

See the linked bug for an instance where the synchronizer failed mid-run and dropped a data row as a result.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136398109
2016-10-17 18:06:43 -04:00
..
sheet Fix off-by-one issue in SheetSynchronizer 2016-10-17 18:06:43 -04:00
BigqueryPollJobAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
BUILD MOE strip compatible_with 2016-08-02 19:14:28 -04:00
CheckSnapshotServlet.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DatastoreBackupInfo.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DatastoreBackupService.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DriveModule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExportConstants.java Rename LrpToken to LrpTokenEntity 2016-10-14 16:58:07 -04:00
ExportDomainListsAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExportRequestModule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExportReservedTermsAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExportSnapshotServlet.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExportUtils.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
LoadSnapshotAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
package-info.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
PublishDetailReportAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
SyncGroupMembersAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
UpdateSnapshotViewAction.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00