mirror of
https://github.com/google/nomulus.git
synced 2025-05-02 04:57:51 +02:00
81dc2bbbc3
This fixes up the following problems: 1. Using string concatenation instead of the formatting variant methods. 2. Logging or swallowing exception messages without logging the exception itself (this swallows the stack trace). 3. Unnecessary logging on re-thrown exceptions. 4. Unnecessary use of formatting variant methods when not necessary. 5. Complicated logging statements involving significant processing not being wrapped inside of a logging level check. 6. Redundant logging both of an exception itself and its message (this is unnecessary duplication). 7. Use of the base Logger class instead of our FormattingLogger class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182419837
64 lines
2.4 KiB
Java
64 lines
2.4 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.monitoring.whitebox;
|
|
|
|
import static com.google.appengine.api.taskqueue.TaskOptions.Builder.withUrl;
|
|
|
|
import com.google.appengine.api.modules.ModulesService;
|
|
import com.google.appengine.api.taskqueue.Queue;
|
|
import com.google.appengine.api.taskqueue.TaskOptions;
|
|
import com.google.appengine.api.taskqueue.TransientFailureException;
|
|
import com.google.common.base.Supplier;
|
|
import google.registry.util.FormattingLogger;
|
|
import java.util.Map.Entry;
|
|
import javax.inject.Inject;
|
|
import javax.inject.Named;
|
|
|
|
/**
|
|
* A collector of metric information. Enqueues collected metrics to a task queue to be written to
|
|
* BigQuery asynchronously.
|
|
*
|
|
* @see MetricsExportAction
|
|
*/
|
|
public class BigQueryMetricsEnqueuer {
|
|
|
|
private static final FormattingLogger logger = FormattingLogger.getLoggerForCallerClass();
|
|
|
|
public static final String QUEUE_BIGQUERY_STREAMING_METRICS = "bigquery-streaming-metrics";
|
|
|
|
@Inject ModulesService modulesService;
|
|
@Inject @Named("insertIdGenerator") Supplier<String> idGenerator;
|
|
@Inject @Named(QUEUE_BIGQUERY_STREAMING_METRICS) Queue queue;
|
|
|
|
@Inject BigQueryMetricsEnqueuer() {}
|
|
|
|
public void export(BigQueryMetric metric) {
|
|
try {
|
|
String hostname = modulesService.getVersionHostname("backend", null);
|
|
TaskOptions opts =
|
|
withUrl(MetricsExportAction.PATH)
|
|
.header("Host", hostname)
|
|
.param("insertId", idGenerator.get());
|
|
for (Entry<String, String> entry : metric.getBigQueryRowEncoding().entrySet()) {
|
|
opts.param(entry.getKey(), entry.getValue());
|
|
}
|
|
opts.param("tableId", metric.getTableId());
|
|
queue.add(opts);
|
|
} catch (TransientFailureException e) {
|
|
// Log and swallow. We may drop some metrics here but this should be rare.
|
|
logger.info(e, "Transient error occurred while recording metric; metric dropped.");
|
|
}
|
|
}
|
|
}
|