mcilwain 4491b7b909 Make loadByForeignKey() and related methods return Optional ... This is safer and addresses a common source of confusion in the codebase because it's always explicit that the resource returned may not be present, whether because it's soft-deleted when projected to the given time or because it never existed in the first place. In production code, the presence of the returned value is always checked. In test code, its presence is assumed using .get() where that is expected and convenient, as it not being present will throw an NPE that will cause the test to fail anyway. Note that the roughly equivalent reloadResourceByForeignKey(), which is widely used in test code, is not having this same treatment applied to it. That is out of the scope of this CL, and has much smaller returns anyway because it's only used in tests (where the unexpected absence of a given resource would just cause the test to fail). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=225424002		2018-12-14 11:24:49 -05:00
..
com/google/testing/builddefs	Format .bzl files with buildifier	2018-07-14 01:37:03 -04:00
google/registry	Make loadByForeignKey() and related methods return Optional	2018-12-14 11:24:49 -05:00