mirror of
https://github.com/google/nomulus.git
synced 2025-05-18 18:29:36 +02:00
ef1487cb57
The absence of these fields causes RDE failures, so they are in effect required on any functioning registry system. We are currently experiencing problems in sandbox caused by null values on these fields. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=155474895
361 lines
16 KiB
Java
361 lines
16 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.export.sheet;
|
|
|
|
import static com.google.common.collect.Iterables.getOnlyElement;
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.config.RegistryConfig.getDefaultRegistrarReferralUrl;
|
|
import static google.registry.config.RegistryConfig.getDefaultRegistrarWhoisServer;
|
|
import static google.registry.model.common.Cursor.CursorType.SYNC_REGISTRAR_SHEET;
|
|
import static google.registry.model.ofy.ObjectifyService.ofy;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.DatastoreHelper.deleteResource;
|
|
import static google.registry.testing.DatastoreHelper.persistNewRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.DatastoreHelper.persistSimpleResources;
|
|
import static org.joda.time.DateTimeZone.UTC;
|
|
import static org.joda.time.Duration.standardMinutes;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.verify;
|
|
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.common.collect.ImmutableMap;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import google.registry.model.common.Cursor;
|
|
import google.registry.model.ofy.Ofy;
|
|
import google.registry.model.registrar.Registrar;
|
|
import google.registry.model.registrar.RegistrarAddress;
|
|
import google.registry.model.registrar.RegistrarContact;
|
|
import google.registry.testing.AppEngineRule;
|
|
import google.registry.testing.FakeClock;
|
|
import google.registry.testing.InjectRule;
|
|
import org.joda.time.DateTime;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.ArgumentCaptor;
|
|
import org.mockito.Captor;
|
|
import org.mockito.Mock;
|
|
import org.mockito.runners.MockitoJUnitRunner;
|
|
|
|
/** Unit tests for {@link SyncRegistrarsSheet}. */
|
|
@RunWith(MockitoJUnitRunner.class)
|
|
public class SyncRegistrarsSheetTest {
|
|
|
|
@Rule
|
|
public final AppEngineRule appEngine = AppEngineRule.builder()
|
|
.withDatastore()
|
|
.build();
|
|
|
|
@Rule
|
|
public final InjectRule inject = new InjectRule();
|
|
|
|
@Captor
|
|
private ArgumentCaptor<ImmutableList<ImmutableMap<String, String>>> rowsCaptor;
|
|
|
|
@Mock
|
|
private SheetSynchronizer sheetSynchronizer;
|
|
|
|
private final FakeClock clock = new FakeClock(DateTime.now(UTC));
|
|
|
|
private SyncRegistrarsSheet newSyncRegistrarsSheet() {
|
|
SyncRegistrarsSheet result = new SyncRegistrarsSheet();
|
|
result.clock = clock;
|
|
result.sheetSynchronizer = sheetSynchronizer;
|
|
return result;
|
|
}
|
|
|
|
@Before
|
|
public void before() throws Exception {
|
|
inject.setStaticField(Ofy.class, "clock", clock);
|
|
createTld("example");
|
|
// Remove Registrar entities created by AppEngineRule.
|
|
for (Registrar registrar : Registrar.loadAll()) {
|
|
deleteResource(registrar);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void test_wereRegistrarsModified_noRegistrars_returnsFalse() throws Exception {
|
|
assertThat(newSyncRegistrarsSheet().wereRegistrarsModified()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void test_wereRegistrarsModified_atDifferentCursorTimes() throws Exception {
|
|
persistNewRegistrar("SomeRegistrar", "Some Registrar Inc.", Registrar.Type.REAL, 8L);
|
|
persistResource(Cursor.createGlobal(SYNC_REGISTRAR_SHEET, clock.nowUtc().minusHours(1)));
|
|
assertThat(newSyncRegistrarsSheet().wereRegistrarsModified()).isTrue();
|
|
persistResource(Cursor.createGlobal(SYNC_REGISTRAR_SHEET, clock.nowUtc().plusHours(1)));
|
|
assertThat(newSyncRegistrarsSheet().wereRegistrarsModified()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void testRun() throws Exception {
|
|
DateTime beforeExecution = clock.nowUtc();
|
|
persistResource(new Registrar.Builder()
|
|
.setClientId("anotherregistrar")
|
|
.setRegistrarName("Another Registrar LLC")
|
|
.setType(Registrar.Type.REAL)
|
|
.setIanaIdentifier(1L)
|
|
.setState(Registrar.State.ACTIVE)
|
|
.setInternationalizedAddress(new RegistrarAddress.Builder()
|
|
.setStreet(ImmutableList.of("I will get ignored :'("))
|
|
.setCity("Williamsburg")
|
|
.setState("NY")
|
|
.setZip("11211")
|
|
.setCountryCode("US")
|
|
.build())
|
|
.setLocalizedAddress(new RegistrarAddress.Builder()
|
|
.setStreet(ImmutableList.of(
|
|
"123 Main St",
|
|
"Suite 100"))
|
|
.setCity("Smalltown")
|
|
.setState("NY")
|
|
.setZip("11211")
|
|
.setCountryCode("US")
|
|
.build())
|
|
.setPhoneNumber("+1.2125551212")
|
|
.setFaxNumber("+1.2125551213")
|
|
.setEmailAddress("contact-us@example.com")
|
|
.setWhoisServer("whois.example.com")
|
|
.setUrl("http://www.example.org/another_registrar")
|
|
.setIcannReferralEmail("jim@example.net")
|
|
.build());
|
|
|
|
Registrar registrar = new Registrar.Builder()
|
|
.setClientId("aaaregistrar")
|
|
.setRegistrarName("AAA Registrar Inc.")
|
|
.setType(Registrar.Type.REAL)
|
|
.setIanaIdentifier(8L)
|
|
.setState(Registrar.State.SUSPENDED)
|
|
.setPassword("pa$$word")
|
|
.setEmailAddress("nowhere@example.org")
|
|
.setInternationalizedAddress(new RegistrarAddress.Builder()
|
|
.setStreet(ImmutableList.of("I get fallen back upon since there's no l10n addr"))
|
|
.setCity("Williamsburg")
|
|
.setState("NY")
|
|
.setZip("11211")
|
|
.setCountryCode("US")
|
|
.build())
|
|
.setAllowedTlds(ImmutableSet.of("example"))
|
|
.setPhoneNumber("+1.2223334444")
|
|
.setUrl("http://www.example.org/aaa_registrar")
|
|
.build();
|
|
ImmutableList<RegistrarContact> contacts = ImmutableList.of(
|
|
new RegistrarContact.Builder()
|
|
.setParent(registrar)
|
|
.setName("Jane Doe")
|
|
.setEmailAddress("contact@example.com")
|
|
.setPhoneNumber("+1.1234567890")
|
|
.setTypes(ImmutableSet.of(RegistrarContact.Type.ADMIN, RegistrarContact.Type.BILLING))
|
|
.build(),
|
|
new RegistrarContact.Builder()
|
|
.setParent(registrar)
|
|
.setName("John Doe")
|
|
.setEmailAddress("john.doe@example.tld")
|
|
.setPhoneNumber("+1.1234567890")
|
|
.setFaxNumber("+1.1234567891")
|
|
.setTypes(ImmutableSet.of(RegistrarContact.Type.ADMIN))
|
|
// Purposely flip the internal/external admin/tech
|
|
// distinction to make sure we're not relying on it. Sigh.
|
|
.setVisibleInWhoisAsAdmin(false)
|
|
.setVisibleInWhoisAsTech(true)
|
|
.setGaeUserId("light")
|
|
.build(),
|
|
new RegistrarContact.Builder()
|
|
.setParent(registrar)
|
|
.setName("Jane Smith")
|
|
.setEmailAddress("pride@example.net")
|
|
.setTypes(ImmutableSet.of(RegistrarContact.Type.TECH))
|
|
.build());
|
|
// Use registrar key for contacts' parent.
|
|
persistSimpleResources(contacts);
|
|
persistResource(registrar);
|
|
|
|
clock.advanceBy(standardMinutes(1));
|
|
newSyncRegistrarsSheet().run("foobar");
|
|
|
|
verify(sheetSynchronizer).synchronize(eq("foobar"), rowsCaptor.capture());
|
|
ImmutableList<ImmutableMap<String, String>> rows = getOnlyElement(rowsCaptor.getAllValues());
|
|
assertThat(rows).hasSize(2);
|
|
|
|
ImmutableMap<String, String> row = rows.get(0);
|
|
assertThat(row).containsEntry("clientIdentifier", "aaaregistrar");
|
|
assertThat(row).containsEntry("registrarName", "AAA Registrar Inc.");
|
|
assertThat(row).containsEntry("state", "SUSPENDED");
|
|
assertThat(row).containsEntry("ianaIdentifier", "8");
|
|
assertThat(row).containsEntry("billingIdentifier", "");
|
|
assertThat(row)
|
|
.containsEntry(
|
|
"primaryContacts",
|
|
""
|
|
+ "Jane Doe\n"
|
|
+ "contact@example.com\n"
|
|
+ "Tel: +1.1234567890\n"
|
|
+ "Types: [ADMIN, BILLING]\n"
|
|
+ "Visible in registrar WHOIS query as Admin contact: No\n"
|
|
+ "Visible in registrar WHOIS query as Technical contact: No\n"
|
|
+ "Phone number and email visible in domain WHOIS query as "
|
|
+ "Registrar Abuse contact info: No\n"
|
|
+ "\n"
|
|
+ "John Doe\n"
|
|
+ "john.doe@example.tld\n"
|
|
+ "Tel: +1.1234567890\n"
|
|
+ "Fax: +1.1234567891\n"
|
|
+ "Types: [ADMIN]\n"
|
|
+ "Visible in registrar WHOIS query as Admin contact: No\n"
|
|
+ "Visible in registrar WHOIS query as Technical contact: Yes\n"
|
|
+ "Phone number and email visible in domain WHOIS query as "
|
|
+ "Registrar Abuse contact info: No\n"
|
|
+ "GAE-UserID: light\n");
|
|
assertThat(row)
|
|
.containsEntry(
|
|
"techContacts",
|
|
""
|
|
+ "Jane Smith\n"
|
|
+ "pride@example.net\n"
|
|
+ "Types: [TECH]\n"
|
|
+ "Visible in registrar WHOIS query as Admin contact: No\n"
|
|
+ "Visible in registrar WHOIS query as Technical contact: No\n"
|
|
+ "Phone number and email visible in domain WHOIS query as "
|
|
+ "Registrar Abuse contact info: No\n");
|
|
assertThat(row).containsEntry("marketingContacts", "");
|
|
assertThat(row).containsEntry("abuseContacts", "");
|
|
assertThat(row).containsEntry("whoisInquiryContacts", "");
|
|
assertThat(row).containsEntry("legalContacts", "");
|
|
assertThat(row)
|
|
.containsEntry(
|
|
"billingContacts",
|
|
""
|
|
+ "Jane Doe\n"
|
|
+ "contact@example.com\n"
|
|
+ "Tel: +1.1234567890\n"
|
|
+ "Types: [ADMIN, BILLING]\n"
|
|
+ "Visible in registrar WHOIS query as Admin contact: No\n"
|
|
+ "Visible in registrar WHOIS query as Technical contact: No\n"
|
|
+ "Phone number and email visible in domain WHOIS query as "
|
|
+ "Registrar Abuse contact info: No\n");
|
|
assertThat(row).containsEntry("contactsMarkedAsWhoisAdmin", "");
|
|
assertThat(row)
|
|
.containsEntry(
|
|
"contactsMarkedAsWhoisTech",
|
|
""
|
|
+ "John Doe\n"
|
|
+ "john.doe@example.tld\n"
|
|
+ "Tel: +1.1234567890\n"
|
|
+ "Fax: +1.1234567891\n"
|
|
+ "Types: [ADMIN]\n"
|
|
+ "Visible in registrar WHOIS query as Admin contact: No\n"
|
|
+ "Visible in registrar WHOIS query as Technical contact: Yes\n"
|
|
+ "Phone number and email visible in domain WHOIS query as "
|
|
+ "Registrar Abuse contact info: No\n"
|
|
+ "GAE-UserID: light\n");
|
|
assertThat(row).containsEntry("emailAddress", "nowhere@example.org");
|
|
assertThat(row).containsEntry(
|
|
"address.street", "I get fallen back upon since there's no l10n addr");
|
|
assertThat(row).containsEntry("address.city", "Williamsburg");
|
|
assertThat(row).containsEntry("address.state", "NY");
|
|
assertThat(row).containsEntry("address.zip", "11211");
|
|
assertThat(row).containsEntry("address.countryCode", "US");
|
|
assertThat(row).containsEntry("phoneNumber", "+1.2223334444");
|
|
assertThat(row).containsEntry("faxNumber", "");
|
|
assertThat(row.get("creationTime")).isEqualTo(beforeExecution.toString());
|
|
assertThat(row.get("lastUpdateTime")).isEqualTo(beforeExecution.toString());
|
|
assertThat(row).containsEntry("allowedTlds", "example");
|
|
assertThat(row).containsEntry("blockPremiumNames", "false");
|
|
assertThat(row).containsEntry("ipAddressWhitelist", "");
|
|
assertThat(row).containsEntry("url", "http://www.example.org/aaa_registrar");
|
|
assertThat(row).containsEntry("icannReferralEmail", "");
|
|
assertThat(row).containsEntry("whoisServer", getDefaultRegistrarWhoisServer());
|
|
assertThat(row).containsEntry("referralUrl", getDefaultRegistrarReferralUrl());
|
|
|
|
row = rows.get(1);
|
|
assertThat(row).containsEntry("clientIdentifier", "anotherregistrar");
|
|
assertThat(row).containsEntry("registrarName", "Another Registrar LLC");
|
|
assertThat(row).containsEntry("state", "ACTIVE");
|
|
assertThat(row).containsEntry("ianaIdentifier", "1");
|
|
assertThat(row).containsEntry("billingIdentifier", "");
|
|
assertThat(row).containsEntry("primaryContacts", "");
|
|
assertThat(row).containsEntry("techContacts", "");
|
|
assertThat(row).containsEntry("marketingContacts", "");
|
|
assertThat(row).containsEntry("abuseContacts", "");
|
|
assertThat(row).containsEntry("whoisInquiryContacts", "");
|
|
assertThat(row).containsEntry("legalContacts", "");
|
|
assertThat(row).containsEntry("billingContacts", "");
|
|
assertThat(row).containsEntry("contactsMarkedAsWhoisAdmin", "");
|
|
assertThat(row).containsEntry("contactsMarkedAsWhoisTech", "");
|
|
assertThat(row).containsEntry("emailAddress", "contact-us@example.com");
|
|
assertThat(row).containsEntry("address.street", "123 Main St\nSuite 100");
|
|
assertThat(row).containsEntry("address.city", "Smalltown");
|
|
assertThat(row).containsEntry("address.state", "NY");
|
|
assertThat(row).containsEntry("address.zip", "11211");
|
|
assertThat(row).containsEntry("address.countryCode", "US");
|
|
assertThat(row).containsEntry("phoneNumber", "+1.2125551212");
|
|
assertThat(row).containsEntry("faxNumber", "+1.2125551213");
|
|
assertThat(row.get("creationTime")).isEqualTo(beforeExecution.toString());
|
|
assertThat(row.get("lastUpdateTime")).isEqualTo(beforeExecution.toString());
|
|
assertThat(row).containsEntry("allowedTlds", "");
|
|
assertThat(row).containsEntry("whoisServer", "whois.example.com");
|
|
assertThat(row).containsEntry("blockPremiumNames", "false");
|
|
assertThat(row).containsEntry("ipAddressWhitelist", "");
|
|
assertThat(row).containsEntry("url", "http://www.example.org/another_registrar");
|
|
assertThat(row).containsEntry("referralUrl", getDefaultRegistrarReferralUrl());
|
|
assertThat(row).containsEntry("icannReferralEmail", "jim@example.net");
|
|
|
|
Cursor cursor = ofy().load().key(Cursor.createGlobalKey(SYNC_REGISTRAR_SHEET)).now();
|
|
assertThat(cursor).isNotNull();
|
|
assertThat(cursor.getCursorTime()).isGreaterThan(beforeExecution);
|
|
}
|
|
|
|
@Test
|
|
public void testRun_missingValues_stillWorks() throws Exception {
|
|
persistNewRegistrar("SomeRegistrar", "Some Registrar", Registrar.Type.REAL, 8L);
|
|
|
|
newSyncRegistrarsSheet().run("foobar");
|
|
|
|
verify(sheetSynchronizer).synchronize(eq("foobar"), rowsCaptor.capture());
|
|
ImmutableMap<String, String> row = getOnlyElement(getOnlyElement(rowsCaptor.getAllValues()));
|
|
assertThat(row).containsEntry("clientIdentifier", "SomeRegistrar");
|
|
assertThat(row).containsEntry("registrarName", "Some Registrar");
|
|
assertThat(row).containsEntry("state", "");
|
|
assertThat(row).containsEntry("ianaIdentifier", "8");
|
|
assertThat(row).containsEntry("billingIdentifier", "");
|
|
assertThat(row).containsEntry("primaryContacts", "");
|
|
assertThat(row).containsEntry("techContacts", "");
|
|
assertThat(row).containsEntry("marketingContacts", "");
|
|
assertThat(row).containsEntry("abuseContacts", "");
|
|
assertThat(row).containsEntry("whoisInquiryContacts", "");
|
|
assertThat(row).containsEntry("legalContacts", "");
|
|
assertThat(row).containsEntry("billingContacts", "");
|
|
assertThat(row).containsEntry("contactsMarkedAsWhoisAdmin", "");
|
|
assertThat(row).containsEntry("contactsMarkedAsWhoisTech", "");
|
|
assertThat(row).containsEntry("emailAddress", "");
|
|
assertThat(row).containsEntry("address.street", "123 Fake St");
|
|
assertThat(row).containsEntry("address.city", "Fakington");
|
|
assertThat(row).containsEntry("address.state", "");
|
|
assertThat(row).containsEntry("address.zip", "");
|
|
assertThat(row).containsEntry("address.countryCode", "US");
|
|
assertThat(row).containsEntry("phoneNumber", "");
|
|
assertThat(row).containsEntry("faxNumber", "");
|
|
assertThat(row).containsEntry("allowedTlds", "");
|
|
assertThat(row).containsEntry("whoisServer", getDefaultRegistrarWhoisServer());
|
|
assertThat(row).containsEntry("blockPremiumNames", "false");
|
|
assertThat(row).containsEntry("ipAddressWhitelist", "");
|
|
assertThat(row).containsEntry("url", "");
|
|
assertThat(row).containsEntry("referralUrl", getDefaultRegistrarReferralUrl());
|
|
assertThat(row).containsEntry("icannReferralEmail", "");
|
|
}
|
|
}
|