mirror of
https://github.com/google/nomulus.git
synced 2025-05-05 06:27:51 +02:00
Many registry tools tests modify system properties but do not restore them to original state. These tests must be isolated from each other and cannot share the same test execution process. This has a huge impact on test performance under Gradle, which seems to have higher process startup overhead. Current Gradle test config has to set 'forEvery' to 1, i.e., every test class must be run in a freshly started process. This change significantly reduces the number of tests that need isolation, making it easier to optimize test config for the remaining tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221350284
115 lines
3.9 KiB
Java
115 lines
3.9 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
|
|
import google.registry.testing.SystemPropertyRule;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link RegistryToolEnvironment}. */
|
|
@RunWith(JUnit4.class)
|
|
public class RegistryToolEnvironmentTest {
|
|
|
|
@Rule public final SystemPropertyRule systemPropertyRule = new SystemPropertyRule();
|
|
|
|
@Test
|
|
public void testGet_withoutSetup_throws() {
|
|
RegistryToolEnvironment.reset();
|
|
assertThrows(IllegalStateException.class, RegistryToolEnvironment::get);
|
|
}
|
|
|
|
@Test
|
|
public void testSetup_changesEnvironmentReturnedByGet() {
|
|
RegistryToolEnvironment.UNITTEST.setup(systemPropertyRule);
|
|
assertThat(RegistryToolEnvironment.get()).isEqualTo(RegistryToolEnvironment.UNITTEST);
|
|
|
|
RegistryToolEnvironment.ALPHA.setup(systemPropertyRule);
|
|
assertThat(RegistryToolEnvironment.get()).isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_shortNotation_works() {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e", "alpha" }))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_longNotation_works() {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "--environment", "alpha" }))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_uppercase_works() {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e", "QA" }))
|
|
.isEqualTo(RegistryToolEnvironment.QA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_equalsNotation_works() {
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "-e=sandbox" }))
|
|
.isEqualTo(RegistryToolEnvironment.SANDBOX);
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(new String[] { "--environment=sandbox" }))
|
|
.isEqualTo(RegistryToolEnvironment.SANDBOX);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_envFlagAfterCommandName_getsIgnored() {
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() ->
|
|
RegistryToolEnvironment.parseFromArgs(
|
|
new String[] {"registrar_activity_report", "-e", "1406851199"}));
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_missingEnvironmentFlag_throwsIae() {
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> RegistryToolEnvironment.parseFromArgs(new String[] {}));
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_extraEnvFlagAfterCommandName_getsIgnored() {
|
|
String[] args = new String[] {
|
|
"-e", "alpha",
|
|
"registrar_activity_report",
|
|
"-e", "1406851199"};
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(args))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_loggingFlagWithUnderscores_isntConsideredCommand() {
|
|
String[] args = new String[] {
|
|
"--logging_properties_file", "my_file.properties",
|
|
"-e", "alpha",
|
|
"list_tlds"};
|
|
assertThat(RegistryToolEnvironment.parseFromArgs(args))
|
|
.isEqualTo(RegistryToolEnvironment.ALPHA);
|
|
}
|
|
|
|
@Test
|
|
public void testFromArgs_badName_throwsIae() {
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> RegistryToolEnvironment.parseFromArgs(new String[] {"-e", "alphaville"}));
|
|
}
|
|
}
|