mirror of
https://github.com/google/nomulus.git
synced 2025-05-03 13:37:51 +02:00
ModulesService does not provide a great API. Specifically, it doesn't have a way to get the hostname for a specific service; you have to get the hostname for a specific version as well. This is very rarely what we want, as we publish new versions every week and don't expect old ones to hang around for very long, so a task should execute against whatever the live version is, not whatever the current version was back when the task was enqueued (especially because that version might be deleted by now). This new and improved wrapper API removes the confusion and plays better with dependency injection to boot. We can also fold in other methods having to do with App Engine services, whereas ModulesService was quite limited in scope. This also has the side effect of fixing ResaveEntityAction, which is currently broken because the tasks it's enqueuing to execute up to 30 days in the future have the version hard-coded into the hostname, and we typically delete old versions sooner than that. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=206173763
253 lines
8.5 KiB
Java
253 lines
8.5 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.appengine.api.taskqueue.QueueFactory.getQueue;
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
import static google.registry.testing.TaskQueueHelper.assertTasksEnqueued;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import com.beust.jcommander.ParameterException;
|
|
import google.registry.testing.InjectRule;
|
|
import google.registry.testing.TaskQueueHelper.TaskMatcher;
|
|
import google.registry.util.AppEngineServiceUtils;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.mockito.Mock;
|
|
|
|
/** Unit tests for {@link GenerateEscrowDepositCommand}. */
|
|
public class GenerateEscrowDepositCommandTest
|
|
extends CommandTestCase<GenerateEscrowDepositCommand> {
|
|
|
|
@Rule
|
|
public final InjectRule inject = new InjectRule();
|
|
|
|
@Mock AppEngineServiceUtils appEngineServiceUtils;
|
|
|
|
@Before
|
|
public void before() {
|
|
createTld("tld");
|
|
createTld("anothertld");
|
|
command = new GenerateEscrowDepositCommand();
|
|
command.appEngineServiceUtils = appEngineServiceUtils;
|
|
command.queue = getQueue("rde-report");
|
|
when(appEngineServiceUtils.getCurrentVersionHostname("backend"))
|
|
.thenReturn("backend.test.localhost");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_missingTld() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand("--watermark=2017-01-01T00:00:00Z", "--mode=thin", "-r 42", "-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("The following option is required: -t, --tld");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_emptyTld() {
|
|
IllegalArgumentException thrown =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=",
|
|
"--watermark=2017-01-01T00:00:00Z",
|
|
"--mode=thin",
|
|
"-r 42",
|
|
"-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("Null or empty TLD specified");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_invalidTld() {
|
|
IllegalArgumentException thrown =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=invalid",
|
|
"--watermark=2017-01-01T00:00:00Z",
|
|
"--mode=thin",
|
|
"-r 42",
|
|
"-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("TLDs do not exist: invalid");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_missingWatermark() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() -> runCommand("--tld=tld", "--mode=full", "-r 42", "-o test"));
|
|
assertThat(thrown)
|
|
.hasMessageThat()
|
|
.contains("The following option is required: -w, --watermark");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_emptyWatermark() {
|
|
IllegalArgumentException thrown =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> runCommand("--tld=tld", "--watermark=", "--mode=full", "-r 42", "-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("Invalid format: \"\"");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_missingOutdir() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=tld", "--watermark=2017-01-01T00:00:00Z", "--mode=thin", "-r 42"));
|
|
assertThat(thrown).hasMessageThat().contains("The following option is required: -o, --outdir");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_emptyOutdir() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=tld",
|
|
"--watermark=2017-01-01T00:00:00Z",
|
|
"--mode=thin",
|
|
"--outdir=",
|
|
"-r 42"));
|
|
assertThat(thrown).hasMessageThat().contains("Output subdirectory must not be empty");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_invalidWatermark() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=tld",
|
|
"--watermark=2017-01-01T10:00:00Z,2017-01-02T00:00:00Z",
|
|
"--mode=thin",
|
|
"-r 42",
|
|
"-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("Each watermark date must be the start of a day");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_invalidMode() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=tld",
|
|
"--watermark=2017-01-01T00:00:00Z",
|
|
"--mode=thing",
|
|
"-r 42",
|
|
"-o test"));
|
|
assertThat(thrown)
|
|
.hasMessageThat()
|
|
.contains("Invalid value for -m parameter. Allowed values:[FULL, THIN]");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_invalidRevision() {
|
|
ParameterException thrown =
|
|
assertThrows(
|
|
ParameterException.class,
|
|
() ->
|
|
runCommand(
|
|
"--tld=tld",
|
|
"--watermark=2017-01-01T00:00:00Z",
|
|
"--mode=thin",
|
|
"-r -1",
|
|
"-o test"));
|
|
assertThat(thrown).hasMessageThat().contains("Revision must be greater than or equal to zero");
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_success() throws Exception {
|
|
runCommand("--tld=tld", "--watermark=2017-01-01T00:00:00Z", "--mode=thin", "-r 42", "-o test");
|
|
|
|
assertTasksEnqueued("rde-report",
|
|
new TaskMatcher()
|
|
.url("/_dr/task/rdeStaging")
|
|
.header("Host", "backend.test.localhost")
|
|
.param("mode", "THIN")
|
|
.param("watermarks", "2017-01-01T00:00:00.000Z")
|
|
.param("tlds", "tld")
|
|
.param("directory", "test")
|
|
.param("manual", "true")
|
|
.param("revision", "42"));
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_successWithDefaultRevision() throws Exception {
|
|
runCommand("--tld=tld", "--watermark=2017-01-01T00:00:00Z", "--mode=thin", "-o test");
|
|
|
|
assertTasksEnqueued("rde-report",
|
|
new TaskMatcher()
|
|
.url("/_dr/task/rdeStaging")
|
|
.header("Host", "backend.test.localhost")
|
|
.param("mode", "THIN")
|
|
.param("watermarks", "2017-01-01T00:00:00.000Z")
|
|
.param("tlds", "tld")
|
|
.param("directory", "test")
|
|
.param("manual", "true"));
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_successWithDefaultMode() throws Exception {
|
|
runCommand("--tld=tld", "--watermark=2017-01-01T00:00:00Z", "-r=42", "-o test");
|
|
|
|
assertTasksEnqueued("rde-report",
|
|
new TaskMatcher()
|
|
.url("/_dr/task/rdeStaging")
|
|
.header("Host", "backend.test.localhost")
|
|
.param("mode", "FULL")
|
|
.param("watermarks", "2017-01-01T00:00:00.000Z")
|
|
.param("tlds", "tld")
|
|
.param("directory", "test")
|
|
.param("manual", "true")
|
|
.param("revision", "42"));
|
|
}
|
|
|
|
@Test
|
|
public void testCommand_successWithMultipleArgumentValues() throws Exception {
|
|
runCommand(
|
|
"--tld=tld,anothertld",
|
|
"--watermark=2017-01-01T00:00:00Z,2017-01-02T00:00:00Z",
|
|
"--mode=thin",
|
|
"-r 42",
|
|
"-o test");
|
|
|
|
assertTasksEnqueued("rde-report",
|
|
new TaskMatcher()
|
|
.url("/_dr/task/rdeStaging")
|
|
.header("Host", "backend.test.localhost")
|
|
.param("mode", "THIN")
|
|
.param("watermarks", "2017-01-01T00:00:00.000Z,2017-01-02T00:00:00.000Z")
|
|
.param("tlds", "tld,anothertld")
|
|
.param("directory", "test")
|
|
.param("manual", "true")
|
|
.param("revision", "42"));
|
|
}
|
|
}
|