mirror of
https://github.com/google/nomulus.git
synced 2025-07-20 01:35:59 +02:00
This CL deduplicates these two methods in DomainTransferRequestFlowTest: - assertHistoryEntriesContainTransferBillingEventsOrGracePeriods() - assertHistoryEntriesDoNotContainTransferBillingEventsOrGracePeriods() Instead, we have one method with an extra parameter dictating whether or not we should expect a transfer billing event (yes normally, no in the case of a superuser transfer w/ 0 period). This is less code overall and avoids drift between the normal vs special case assertions (if people make changes in one but forget to do so in the other). Also, the methods as named were a little confusing because the "Contain" vs "DoNotContain" naming suggests that the methods are asserting opposite things, but actually they assert some things in common (like the existence of autorenew billing events, and that pre-transfer grace periods are cleared). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=170540417 |
||
---|---|---|
.. | ||
google/registry |