zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-04-30 12:07:51 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/testing
History
cgoldfeder 2d518ed666 Move thrown.expect() right before the throwing statement 
aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407
2016-10-14 16:58:07 -04:00
..
mapreduce Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
sftp Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
AbstractDomainBaseSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
AbstractEppResourceSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
AppEngineRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
BouncyCastleProviderRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
BUILD Add dagger map for injecting DnsWriter implementations 2016-08-05 20:38:21 -04:00
CertificateSamples.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ContactResourceSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DatastoreHelper.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
default_premium_list_testdata.csv mv com/google/domain/registry google/registry 2016-05-13 18:55:08 -04:00
DeterministicStringGenerator.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DomainApplicationSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
DomainResourceSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
EppExceptionSubject.java Move thrown.expect() right before the throwing statement 2016-10-14 16:58:07 -04:00
EppLoader.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ExceptionRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FailAnswer.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeClock.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeHttpSession.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeJsonResponse.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeResponse.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeServletInputStream.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeServletOutputStream.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeSleeper.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FakeURLFetchService.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ForwardingURLFetchService.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
FullFieldsTestEntityHelper.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
GcsTestingUtils.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
GenericEppResourceSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
GpgSystemCommandRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
HistoryEntrySubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
HostResourceSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
InjectRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
IoSpyRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
logging.properties Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
LogsSubject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
package-info.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
Providers.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ReflectiveFieldExtractor.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ReflectiveSubjectFactory.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
RegistryConfigRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
ShardableTestCase.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
SlurpAnswer.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
SystemInfo.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
SystemPropertyRule.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
TaskQueueHelper.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
TestDataHelper.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
TestObject.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
TruthChainer.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
UriParameters.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
UserInfo.java Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00