mirror of
https://github.com/google/nomulus.git
synced 2025-07-26 04:28:34 +02:00
e8eabe01cf
PDT testing revealed a couple ways in which our WHOIS output was non-compliant. First, the Consistent Labeling & Display policy dictates that the contact IDs must be ROIDs. See rule 11 in https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en. Second, PDT tests expect that a WHOIS response will treat missing values either by omitting the line entirely, or by including the line with a blank value, but not both. So this is legal: Phone Number: 123-4567 Phone Number Ext: Fax Number: 123-4568 Fax Number Ext: and this is legal: Phone Number: 123-4567 Fax Number: 123-4568 but this is not: Phone Number: 123-4567 Phone Number Ext: Fax Number: 123-4568 In the last example, one extension line is present with a blank value, while the other extension line is omitted. We cannot do both. Therefore, we should update our code to omit lines with no value. Since we can't guarantee that we will always emit all lines that the parse might expect to see, it is safe to use the policy of omitting lines with no value. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158184150 |
||
|---|---|---|
| .. | ||
| BUILD | ||
| DomainLookupCommand.java | ||
| DomainOrHostLookupCommand.java | ||
| DomainWhoisResponse.java | ||
| NameserverLookupByHostCommand.java | ||
| NameserverLookupByIpCommand.java | ||
| NameserverWhoisResponse.java | ||
| package-info.java | ||
| RegistrarLookupCommand.java | ||
| RegistrarWhoisResponse.java | ||
| Whois.java | ||
| WhoisCommand.java | ||
| WhoisCommandFactory.java | ||
| WhoisException.java | ||
| WhoisHttpServer.java | ||
| WhoisMetrics.java | ||
| WhoisModule.java | ||
| WhoisReader.java | ||
| WhoisResponse.java | ||
| WhoisResponseImpl.java | ||
| WhoisServer.java | ||