zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-30 01:10:14 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/tools
History
cgoldfeder 5098b03af4 DeReference the codebase 
This change replaces all Ref objects in the code with Key objects. These are
stored in datastore as the same object (raw datastore keys), so this is not
a model change.

Our best practices doc says to use Keys not Refs because:
 * The .get() method obscures what's actually going on
   - Much harder to visually audit the code for datastore loads
   - Hard to distinguish Ref<T> get()'s from Optional get()'s and Supplier get()'s
 * Implicit ofy().load() offers much less control
   - Antipattern for ultimate goal of making Ofy injectable
   - Can't control cache use or batch loading without making ofy() explicit anyway
 * Serialization behavior is surprising and could be quite dangerous/incorrect
   - Can lead to serialization errors. If it actually worked "as intended",
     it would lead to a Ref<> on a serialized object being replaced upon
     deserialization with a stale copy of the old value, which could potentially
     break all kinds of transactional expectations
 * Having both Ref<T> and Key<T> introduces extra boilerplate everywhere
   - E.g. helper methods all need to have Ref and Key overloads, or you need to
     call .key() to get the Key<T> for every Ref<T> you want to pass in
   - Creating a Ref<T> is more cumbersome, since it doesn't have all the create()
     overloads that Key<T> has, only create(Key<T>) and create(Entity) - no way to
     create directly from kind+ID/name, raw Key, websafe key string, etc.

(Note that Refs are treated specially by Objectify's @Load method and Keys are not;
we don't use that feature, but it is the one advantage Refs have over Keys.)

The direct impetus for this change is that I am trying to audit our use of memcache,
and the implicit .get() calls to datastore were making that very hard.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131965491
2016-09-02 13:50:20 -04:00
..
params Standardize test methods to be prefixed with "test" 2016-08-26 09:41:52 -04:00
server DeReference the codebase 2016-09-02 13:50:20 -04:00
testdata Add registry_tool host_create command 2016-08-22 14:45:54 -04:00
AllocateDomainCommandTest.java DeReference the codebase 2016-09-02 13:50:20 -04:00
BUILD Add gTech command to get .app domain info 2016-07-19 10:42:13 -04:00
CommandTestCase.java Add domain application create history to LrpToken 2016-08-02 19:15:31 -04:00
CreateAnchorTenantCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateContactCommandTest.java Add create_domain command to gtech_tool 2016-08-15 16:53:01 -04:00
CreateCreditBalanceCommandTest.java DeReference the codebase 2016-09-02 13:50:20 -04:00
CreateCreditCommandTest.java DeReference the codebase 2016-09-02 13:50:20 -04:00
CreateDomainCommandTest.java Remove redundant run commmands in CreateDomainCommandTest 2016-08-22 14:47:18 -04:00
CreateHostCommandTest.java Add registry_tool host_create command 2016-08-22 14:45:54 -04:00
CreateOrUpdatePremiumListCommandTestCase.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateOrUpdateReservedListCommandTestCase.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreatePremiumListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateRegistrarCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateRegistrarGroupsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateReservedListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
CreateTldCommandTest.java Add LRP TLD states to Registry and *_tld tools 2016-08-05 20:41:11 -04:00
DeleteCreditCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DeleteDomainCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DeleteEntityCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DeletePremiumListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DeleteReservedListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DomainApplicationInfoCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DomainCheckClaimsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DomainCheckCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
DomainCheckFeeCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EncryptEscrowDepositCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppToolCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppToolCommandTestCase.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
EppToolVerifier.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ExecuteEppCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakePasswordGenerator.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GenerateAuctionDataCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GenerateDnsReportCommandTest.java DeReference the codebase 2016-09-02 13:50:20 -04:00
GenerateEscrowDepositCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetApplicationCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetApplicationIdsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetClaimsListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetContactCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetDomainCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetHostCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetLrpTokenCommandTest.java Move LRP token and tools into domain package 2016-08-02 19:22:44 -04:00
GetRegistrarCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetResourceByKeyCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetSchemaTreeCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GetTldCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GhostrydeCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GtechToolTest.java Normalize expected exception handling in tests 2016-08-02 19:16:19 -04:00
ListCursorsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ListDomainsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ListHostsCommandTest.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ListObjectsCommandTestCase.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ListPremiumListsCommandTest.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ListRegistrarsCommandTest.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ListReservedListsCommandTest.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ListTldsCommandTest.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
MutatingCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
PublishDetailReportCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
RegistrarContactCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
RegistryToolEnvironmentTest.java Normalize expected exception handling in tests 2016-08-02 19:16:19 -04:00
RegistryToolTest.java Normalize expected exception handling in tests 2016-08-02 19:16:19 -04:00
ResaveEnvironmentEntitiesCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
SetupOteCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UniformRapidSuspensionCommandTest.java DeReference the codebase 2016-09-02 13:50:20 -04:00
UpdateApplicationStatusCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateClaimsNoticeCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateCursorsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdatePremiumListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateRegistrarCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateReservedListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateServerLocksCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateSmdCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UpdateTldCommandTest.java Add LRP TLD states to Registry and *_tld tools 2016-08-05 20:41:11 -04:00
UploadClaimsListCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ValidateEscrowDepositCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ValidateLoginCredentialsCommandTest.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00