google-nomulus/java/google/registry/flows
cgoldfeder 223e8c2316 Fix a null check bug in HostUpdateFlow
This bug is about a bad use of Optional.
We were checking == null instead of .isPresent(), so the check
always passed, and we always set a lastSubordinateTime when
updating hosts, even if the host was external and should have
had a null value in that field.

There is almost certainly bad data in prod in the sense
that any external host that was ever updated will have a value
for this field instead of null. However, this is not
consequential as the field is entirely meaningless for
external hosts, and will be properly reset if the host is
ever moved to be internal.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=146363178
2017-02-02 17:16:32 -05:00
..
async Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
contact Remove unnecessary filter on LINKED 2017-02-02 16:41:39 -05:00
custom Fix an annoying Javadoc nit 2017-02-02 16:47:28 -05:00
domain Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
exceptions Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
host Fix a null check bug in HostUpdateFlow 2017-02-02 17:16:32 -05:00
picker Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
poll Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
session Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
soy Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Restructure Maven dependencies in build 2017-01-09 11:59:04 -05:00
CheckApiAction.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppConsoleAction.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppController.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppException.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetrics.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestHandler.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppRequestSource.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppTlsAction.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppToolAction.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppXmlTransformer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ExtensionManager.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Flow.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowComponent.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowModule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowRunner.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowScope.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GaeUserCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HttpSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PasswordOnlyTransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ResourceFlowUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
StatelessRequestSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TlsCredentials.java Fix a deprecated method now that we are on Guava 20 2017-02-02 16:50:20 -05:00
TransactionalFlow.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00