mirror of
https://github.com/google/nomulus.git
synced 2025-08-03 00:12:11 +02:00
29e330a78d
* Make PremiumList.labelsToPrices "insignificant" Add the ImmutableObject.Insignificant annotation to labelsToPrices and also mark it as Transient. In order to do lazy-loads on this field, we need to do so explicitly: doing otherwise breaks the immutability contract and prevents detaching the object upon load. Note that this is an expedient solution to this problem, but not the optimal one. Ideally, the disassociation between PremiumList and its PremiumEntry's would be more explicit. However, breaking labelsToPrices out would at minimum require reworking the Create/UpdatePremiumList commands, which currently rely on passing around a self-contained PremiumList object, both from the parser interfaces and to the database. If this approach is acceptable, we can apply it to ReservedList and ClaimsList as well (though it may be easier to break the association in those cases). * Fix premium list "delete" to support a test * Fix a few more tests * Changes for review (updated javadocs) * Minor fixes * Updated getLablesToPrices() comment * Format fixes, fixed PremiumEntry interfaces PremiumEntry can now be SQL only. |
||
|---|---|---|
| .. | ||
| gradle/dependency-locks | ||
| src | ||
| WEB-INF/appengine-generated | ||
| build.gradle | ||
| Dockerfile | ||