google-nomulus/javatests/google/registry/dns
larryruili 6280d74f1c Fix CloudDnsWriter glue record A/AAAA arguments
Previously, CloudDnsWriter used InetAddress.toString() to produce the ipv4/6
address string (i.e. 127.0.0.1 or 0:0:0:0:0:0:0:1) used as an argument to the
Cloud DNS API. However, this fails because InetAddress uses the format
"HostName/IpAddress" for toString(), which uses the empty string as a HostName
if unspecified. This resulted in the erroneous use of a prefix slash (i.e.
"/127.0.01") as an InetAddress argument, causing all glue record updates to
fail.

This change replaces InetAddress.toString() with InetAddress.getHostAddress(),
which properly generates the IP address for the InetAddress. This also replaces
a lot of logic in the corresponding test with concrete equivalents, preventing
obvious errors like this from creeping up on us in the future.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=184708896
2018-02-20 15:11:18 -05:00
..
writer Fix CloudDnsWriter glue record A/AAAA arguments 2018-02-20 15:11:18 -05:00
BUILD Move backported JUnit file to third_party (part 2) 2017-12-02 11:37:46 -05:00
DnsInjectionTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
DnsQueueTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00
DnsTestComponent.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PublishDnsUpdatesActionTest.java Add label for the DnsWriter in the publishDnsUpdates metrics 2018-01-19 14:53:21 -05:00
ReadDnsQueueActionTest.java Remove "keepTasks" from ReadDnsQueueAction 2018-02-01 22:05:40 -05:00
RefreshDnsActionTest.java Automatically refactor more exception testing to use new JUnit rules 2017-12-27 10:42:36 -05:00