mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 03:57:51 +02:00
22ef38fc3f
This PR fixes the issue where the onetime billing event for an autorenew is not correctly created if the recurrence of the autorenew is closed during the autorenew grace period, such as the case if a manual renew happens during the same grace period. The detailed analysis of the issue is captured in b/258822640. Note that this is a quick and dirty fix to make ongoing billing event expanse work correctly in the future. It does not fix the missing events in the past, nor can it be used to reconstruct the missing ones (by providing a different cursor time), due to timeout when triggering the action from nomulus curl. Per Weimin, the recurrences that fits the new condition along, based on the current cursor, would increase from 382k to 430k, a 12% increase. I checked last nights cron job run, which starts on 22:00 EST and seemed to finish at 22:15 EST (when the last log for this request was recorded), so it should definitely still finish in time for the nightly runs with the new condition. |
||
|---|---|---|
| .. | ||
| src | ||
| build.gradle | ||
| buildscript-gradle.lockfile | ||
| Dockerfile | ||
| gradle.lockfile | ||