google-nomulus/javatests/google/registry
cgoldfeder 223e8c2316 Fix a null check bug in HostUpdateFlow
This bug is about a bad use of Optional.
We were checking == null instead of .isPresent(), so the check
always passed, and we always set a lastSubordinateTime when
updating hosts, even if the host was external and should have
had a null value in that field.

There is almost certainly bad data in prod in the sense
that any external host that was ever updated will have a value
for this field instead of null. However, this is not
consequential as the field is entirely meaningless for
external hosts, and will be properly reset if the host is
ever moved to be internal.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=146363178
2017-02-02 17:16:32 -05:00
..
backup Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
batch Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
bigquery Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
builddefs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
config Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
cron Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
dns Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
export Convert yet more configuration options to YAML 2017-02-02 17:05:28 -05:00
flows Fix a null check bug in HostUpdateFlow 2017-02-02 17:16:32 -05:00
groups Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
mapreduce/inputs Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
model Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
module Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
monitoring Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
pricing Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
rdap Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
rde Document StatusValue better and add per-resource restrictions 2017-02-02 16:46:02 -05:00
request Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
security Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
server Comment and deprecation nits 2017-02-02 17:13:47 -05:00
storage/drive Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
testing Fix two deprecated uses of Files methods 2017-02-02 17:15:10 -05:00
tldconfig/idn Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tmch Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
tools Replace more uses of deprecated getHostText() with getHost() 2017-02-02 17:11:00 -05:00
ui Suppress a warning in a test 2017-02-02 17:09:36 -05:00
util Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
whois Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
xjc Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
xml Update copyright year on all license headers 2017-02-02 16:27:22 -05:00