google-nomulus/java/google/registry/tools/server
guyben 9d2b1e7572 Consolidate all Set parameter parsing
Currently, we have two different ways to parse a "set" parameter:
key=value1&key=value2&key=value3...
and
keys=value1,value2,value3

This is error prone for several reasons:
- different parts of the code must be "synchronized" to use the same style (the
  place that creates the request, and the place that parses the request)
- for the key=value1&key=value2, we often use the same key name for the single
  value and the set value. This can result in subtle bugs where part of the
  code will successfully read the key assuming there's only one key (and will
  get the first key=value1, ignoring the rest)

Here we transition everything to the keys=value1,value2,value3 method. This one
was chosen because:
- it's shorter
- it's more intuitive for users
- the key name is plural, differentiating it from the singular key=value that
  other requests might need

-----------------------------------

To make sure there are not "transition issues", we will continue to support
(with warnings) the key=value1&key=value2 parameter parsing until we're sure we
haven't forgotten to update any part of the code.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=198810681
2018-06-06 15:04:02 -04:00
..
BUILD Migrate to Flogger (green) 2018-05-30 12:18:54 -04:00
CreateGroupsAction.java Migrate to Flogger (green) 2018-05-30 12:18:54 -04:00
CreateOrUpdatePremiumListAction.java Migrate to flogger (red) 2018-05-30 12:18:54 -04:00
CreatePremiumListAction.java Migrate to flogger (red) 2018-05-30 12:18:54 -04:00
DeleteEntityAction.java Migrate to Flogger (green) 2018-05-30 12:18:54 -04:00
GenerateZoneFilesAction.java Migrate Guava Predicates.notNull to Objects.nonNull 2017-12-27 11:19:53 -05:00
KillAllCommitLogsAction.java Replace Stream.concat with Streams.concat 2017-12-27 11:35:47 -05:00
KillAllEntitiesReducer.java Replace many Work and VoidWork usages with lambdas 2017-11-21 18:45:12 -05:00
KillAllEppResourcesAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
ListDomainsAction.java Consolidate all Set parameter parsing 2018-06-06 15:04:02 -04:00
ListHostsAction.java Run automatic Java 8 conversion over codebase 2017-10-10 12:09:41 -04:00
ListObjectsAction.java Migrate to Flogger (green) 2018-05-30 12:18:54 -04:00
ListPremiumListsAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
ListRegistrarsAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
ListReservedListsAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
ListTldsAction.java Run automatic Java 8 conversion over codebase 2017-10-10 12:09:41 -04:00
PollMapreduceAction.java Add PollMapreduceAction 2017-09-12 15:51:44 -04:00
RefreshDnsForAllDomainsAction.java Consolidate all Set parameter parsing 2018-06-06 15:04:02 -04:00
ResaveAllHistoryEntriesAction.java Replace many Work and VoidWork usages with lambdas 2017-11-21 18:45:12 -05:00
ToolsServerModule.java Consolidate all Set parameter parsing 2018-06-06 15:04:02 -04:00
UpdatePremiumListAction.java Migrate to flogger (red) 2018-05-30 12:18:54 -04:00
VerifyOteAction.java Add per-test output to verify_ote command in --summarize mode 2018-04-02 16:50:42 -04:00