mirror of
https://github.com/google/nomulus.git
synced 2025-05-16 17:37:13 +02:00
The console will have 2 different "updatable things": - only ADMINs (GAE-admins and users in the support G-Suite group) can change the things in the "admin settings" tab (currently just the allowed TLDs) - only OWNERs can change things from the other tabs: WHOIS info, certificates, whitelisted IPs, contacts etc. Also, all ADMINs are now OWNERS of "non-REAL" registrars. Meaning - we're only preventing ADMINs from editing "REAL" registrars (usually in production). Specifically, OTE registrars on sandbox are NOT "REAL", meaning ADMINS will still be able to update them. This only changes the backend (registrar-settings endpoint). As-is, the console website will still make ADMINs *think* they can change everything, but if they try - they will get an error. Changing the frontend will happen in the next CL - because I want to get this out this release cycle and getting JS reviewed takes a long time :( TESTED=deployed to alpha, and saw I can't update fields even as admin on REAL registrars, but could change it on non-REAL registrars. Also checked that I can update the allowed TLDs on REAL registrars ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222698270
148 lines
6.4 KiB
Java
148 lines
6.4 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.ui.server.registrar;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT2;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT2_HASH;
|
|
import static google.registry.testing.CertificateSamples.SAMPLE_CERT_HASH;
|
|
import static google.registry.testing.DatastoreHelper.loadRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.util.DateTimeUtils.START_OF_TIME;
|
|
import static java.util.Arrays.asList;
|
|
|
|
import com.google.common.collect.ImmutableMap;
|
|
import google.registry.model.registrar.Registrar;
|
|
import java.util.Map;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/**
|
|
* Unit tests for security_settings.js use of {@link RegistrarSettingsAction}.
|
|
*
|
|
* <p>The default read and session validation tests are handled by the
|
|
* superclass.
|
|
*/
|
|
@RunWith(JUnit4.class)
|
|
public class SecuritySettingsTest extends RegistrarSettingsActionTestCase {
|
|
|
|
@Test
|
|
public void testPost_updateCert_success() {
|
|
Registrar modified =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT, clock.nowUtc())
|
|
.build();
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update",
|
|
"id", CLIENT_ID,
|
|
"args", modified.toJsonMap()));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
assertThat(response).containsEntry("results", asList(modified.toJsonMap()));
|
|
assertThat(loadRegistrar(CLIENT_ID)).isEqualTo(modified);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testPost_updateCert_failure() {
|
|
Map<String, Object> reqJson = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
reqJson.put("clientCertificate", "BLAH");
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update",
|
|
"id", CLIENT_ID,
|
|
"args", reqJson));
|
|
assertThat(response).containsEntry("status", "ERROR");
|
|
assertThat(response).containsEntry("message", "Invalid X.509 PEM certificate");
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "ERROR: FormFieldException");
|
|
}
|
|
|
|
@Test
|
|
public void testChangeCertificates() {
|
|
Map<String, Object> jsonMap = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
jsonMap.put("clientCertificate", SAMPLE_CERT);
|
|
jsonMap.put("failoverClientCertificate", null);
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getClientCertificate()).isEqualTo(SAMPLE_CERT);
|
|
assertThat(registrar.getClientCertificateHash()).isEqualTo(SAMPLE_CERT_HASH);
|
|
assertThat(registrar.getFailoverClientCertificate()).isNull();
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isNull();
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testChangeFailoverCertificate() {
|
|
Map<String, Object> jsonMap = loadRegistrar(CLIENT_ID).toJsonMap();
|
|
jsonMap.put("failoverClientCertificate", SAMPLE_CERT2);
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getFailoverClientCertificate()).isEqualTo(SAMPLE_CERT2);
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isEqualTo(SAMPLE_CERT2_HASH);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testEmptyOrNullCertificate_doesNotClearOutCurrentOne() {
|
|
Registrar initialRegistrar =
|
|
persistResource(
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT, START_OF_TIME)
|
|
.setFailoverClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build());
|
|
Map<String, Object> jsonMap = initialRegistrar.toJsonMap();
|
|
jsonMap.put("clientCertificate", null);
|
|
jsonMap.put("failoverClientCertificate", "");
|
|
Map<String, Object> response = action.handleJsonRequest(ImmutableMap.of(
|
|
"op", "update", "id", CLIENT_ID, "args", jsonMap));
|
|
assertThat(response).containsEntry("status", "SUCCESS");
|
|
Registrar registrar = loadRegistrar(CLIENT_ID);
|
|
assertThat(registrar.getClientCertificate()).isEqualTo(SAMPLE_CERT);
|
|
assertThat(registrar.getClientCertificateHash()).isEqualTo(SAMPLE_CERT_HASH);
|
|
assertThat(registrar.getFailoverClientCertificate()).isEqualTo(SAMPLE_CERT2);
|
|
assertThat(registrar.getFailoverClientCertificateHash()).isEqualTo(SAMPLE_CERT2_HASH);
|
|
assertMetric(CLIENT_ID, "update", "[OWNER]", "SUCCESS");
|
|
}
|
|
|
|
@Test
|
|
public void testToJsonMap_containsCertificate() {
|
|
Map<String, Object> jsonMap =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build()
|
|
.toJsonMap();
|
|
assertThat(jsonMap).containsEntry("clientCertificate", SAMPLE_CERT2);
|
|
assertThat(jsonMap).containsEntry("clientCertificateHash", SAMPLE_CERT2_HASH);
|
|
}
|
|
|
|
@Test
|
|
public void testToJsonMap_containsFailoverCertificate() {
|
|
Map<String, Object> jsonMap =
|
|
loadRegistrar(CLIENT_ID)
|
|
.asBuilder()
|
|
.setFailoverClientCertificate(SAMPLE_CERT2, START_OF_TIME)
|
|
.build()
|
|
.toJsonMap();
|
|
assertThat(jsonMap).containsEntry("failoverClientCertificate", SAMPLE_CERT2);
|
|
assertThat(jsonMap).containsEntry("failoverClientCertificateHash", SAMPLE_CERT2_HASH);
|
|
}
|
|
}
|