nickfelt 16832323d0 Make ListObjectsAction return 200 when sending JSON error ... This fixes a bug in the interaction between ListObjectsAction and ListObjectsCommand/AppEngineConnection. ListObjectsAction was returning HTTP status code 400 when it caught an IAE, but also attempting to return a JSON response payload of {"status": "error", "error": "<exception message>"}. However, AppEngineConnection treats any HTTP error response as more like a crash on the server side - it attempts to scrape the error message out of the autogenerated HTML that AppEngine produces for uncaught exceptions, and throws an exception, killing ListObjectsCommand before it can extract the JSON which contains the nicer error (that stating the missing field, etc versus just "400 Bad Request"). The fix is just to have ListObjectsAction return a 200 and the error message so that ListObjectsCommand can correctly handle it. I also de-scoped the catch to only catching IAE, since catching Exception was overbroad, and the only "expected" exception to be thrown is an IAE from the checkArgument() that tests if the requested fields all exist. Any other kinds of exceptions should actually just bubble up and kill the action, and get the regular AppEngineConnection error treatment. I also added "billingId" as an alias for "billingIdentifier", parallel to clientId/clientIdentifier, since that's why I came across this issue in the first place. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148248834		2017-02-27 11:10:37 -05:00
..
com/google/testing/builddefs	Update copyright year on all license headers	2017-02-02 16:27:22 -05:00
google/registry	Make ListObjectsAction return 200 when sending JSON error	2017-02-27 11:10:37 -05:00