mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 03:57:51 +02:00
139a84bef6
The main purpose of this PR is to help debug b/234189023, where a registrar reported that in sandbox they observed seemingly successful EPP update responses to delete NS records, which are not actually deleted after the commands executed. To actually load the persisted domain resource after an update would require us to execute another transaction immediately after the update transaction and that can only be achieved outside the flow (i. e. in FlowRunner or EppController) and we need to test for the type of flows before logging, which seems unnecessarily complex. For now we are just adding logs inside the update transaction itself to validate that: 1. The NS records to delete are as expected. 2. The Current NS records are as expected. 3. The new NS records to persist are as expected. The EPP success reply is the default reply when no errors are thrown in a transaction. If we see a success reply (which means that the transaction finished successfully) and expected logs from the transaction, the only explanation could be that somewhere in the ORM layer the java representation of what the entity is is different from what is being presented to the database. I think that signals a much bigger and fundamental problem, which is quite unlikely given how isolated the issue under consideration is. In any case we would like to add the logging functionality in sandbox and ask the registrar to report again when they see similar issues. Also made some typo and linting fixes. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/google/nomulus/1663) <!-- Reviewable:end --> |
||
|---|---|---|
| .. | ||
| gradle/dependency-locks | ||
| src | ||
| build.gradle | ||
| Dockerfile | ||
