mirror of
https://github.com/google/nomulus.git
synced 2025-05-04 05:57:51 +02:00
0859cde790
In the previous CL I added filter support for the test server, but even though I could verify that filters were being run when debugging, in practice the side effects of the filters (notably, ObjectifyFilter clearing the session cache) were somehow not present in tests (and therefore causing new as-yet unsubmitted tests that rely on proper session caching to break). Investigating further, the way TestServer works is that it creates a wrapper Servlet for each route, and in that wrapper just pushes a future onto a queue and waits on it. The actual target servlet is run within the queue, not within the wrapper servlet's context. I had added filters to the *wrapper* servlet, which meant that even though they were invoked before adding the task to the queue, they were not invoked in the process of actually running the task. In this CL I pushed the filters into the task itself, just like the target servlet. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=144123637 |
||
|---|---|---|
| .. | ||
| BUILD | ||
| Fixture.java | ||
| HealthzServlet.java | ||
| RegistryTestServer.java | ||
| RegistryTestServerMain.java | ||
| Route.java | ||
| ServletWrapperDelegatorServlet.java | ||
| StaticResourceServlet.java | ||
| TestServer.java | ||
| UrlChecker.java | ||